-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11394. Fix hadoop-yarn-server-resourcemanager module Java Doc Errors. #5288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
When completing some PRs of YARN, RM will prompt a java doc error, which makes the compilation report fail. I try to fix the java doc error of RM. @ayushtkn Can you help review this pr? Thank you very much! |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@ayushtkn @goiri Can you help review this PR? Thank you very much! We use JDK11 to compile RM, java doc error will cause some PRs to fail the yetus test. RM Javadoc Error will appear in the following PRs: In this pr, I fixed the problem of java doc, which can already be compiled by yetus. The modified compilation results are as follows: |
|
For JDK-11 javadoc there is already a ticket in hadoop common. I think that should fix most of the things. Should wait for it IMO |
|
@ayushtkn Thanks for the explanation, I agree with you! |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@ayushtkn Can we follow up on this pr? Can you help with review? Thank you very much! These PRs will cause compilation errors due to RM java doc. YARN-11424. [Federation] Router Supports DeregisterSubCluster.(#5363) |
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The build is green. That is what I validated.
cc. @steveloughran in case you want to check.
|
@steveloughran Can you help review this pr? Thank you very much! |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@steveloughran Can you help review this pr? Thank you very much! @ayushtkn @goiri Can we merge this pr to the trunk branch? These PRs will cause compilation errors due to RM java doc. YARN-11424. [Federation] Router Supports DeregisterSubCluster.(#5363) |
steveloughran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
+1
|
in trunk; cherrypick to branch-3.3 if you can... |
|
@ayushtkn @steveloughran Thank you for your help to review the code, I will cherrypick to branch3-3. |
…rors. (apache#5288) Contributed by Shilun Fan
…rors. (#5288) Contributed by Shilun Fan
…rors. (apache#5288) Contributed by Shilun Fan

JIRA: YARN-11394. Fix hadoop-yarn-server-resourcemanager module Java Doc Errors.