YARN-11424. Fix CheckStyle.

Author: slfan1989

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java

@@ -4302,7 +4302,8 @@ public static boolean isAclEnabled(Configuration conf) {
   /** Subcluster timeout allowed by Router.  **/
   public static final String ROUTER_SUBCLUSTER_EXPIRATION_TIME =
       ROUTER_PREFIX + "subcluster.heartbeat.expiration.time";
-  public static final long DEFAULT_ROUTER_SUBCLUSTER_EXPIRATION_TIME = 1800000;
+  public static final long DEFAULT_ROUTER_SUBCLUSTER_EXPIRATION_TIME =
+      TimeUnit.MINUTES.toMillis(30);;
 
   ////////////////////////////////
   // CSI Volume configs

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java

@@ -74,10 +74,17 @@ private static void buildHelpMsg(String cmd, StringBuilder builder) {
 
     if (usageInfo.args != null) {
       String space = (usageInfo.args == "") ? "" : " ";
-      builder.append("   " + cmd + space + usageInfo.args + ": "
-              + usageInfo.help);
+      builder.append("   ")
+          .append(cmd)
+          .append(space)
+          .append(usageInfo.args)
+          .append(": ")
+          .append(usageInfo.help);
     } else {
-      builder.append("   " + cmd + ": " + usageInfo.help);
+      builder.append("   ")
+          .append(cmd)
+          .append(": ")
+          .append(usageInfo.help);
     }
   }
 
@@ -87,29 +94,35 @@ private static void buildIndividualUsageMsg(String cmd, StringBuilder builder) {
       return;
     }
     if (usageInfo.args == null) {
-      builder.append("Usage: routeradmin [" + cmd + "]\n");
+      builder.append("Usage: routeradmin [")
+          .append(cmd)
+          .append("]\n");
     } else {
       String space = (usageInfo.args == "") ? "" : " ";
-      builder.append("Usage: routeradmin [" + cmd + space + usageInfo.args + "]\n");
+      builder.append("Usage: routeradmin [")
+          .append(cmd)
+          .append(space)
+          .append(usageInfo.args)
+          .append("]\n");
     }
   }
 
   private static void printHelp() {
     StringBuilder summary = new StringBuilder();
-    summary.append("router-admin is the command to execute " +
-        "YARN Federation administrative commands.\n");
-    summary.append("The full syntax is: \n\n"
-        + "routeradmin"
-        + " [-deregisterSubCluster [-c|clusterId [subClusterId]]");
+    summary.append("router-admin is the command to execute ")
+        .append("YARN Federation administrative commands.\n");
+    summary.append("The full syntax is: \n\n")
+        .append("routeradmin")
+        .append(" [-deregisterSubCluster [-c|clusterId [subClusterId]]");
     summary.append(" [-help [cmd]]").append("\n");
     StringBuilder helpBuilder = new StringBuilder();
     System.out.println(summary);
     for (String cmdKey : ADMIN_USAGE.keySet()) {
       buildHelpMsg(cmdKey, helpBuilder);
       helpBuilder.append("\n");
     }
-    helpBuilder.append("   -help [cmd]: Displays help for the given command or all commands" +
-        " if none is specified.");
+    helpBuilder.append("   -help [cmd]: Displays help for the given command or all commands")
+        .append(" if none is specified.");
     System.out.println(helpBuilder);
     System.out.println();
     ToolRunner.printGenericCommandUsage(System.out);
@@ -127,9 +140,13 @@ private static void buildUsageMsg(StringBuilder builder) {
     builder.append("Usage: router-admin\n");
     for (Map.Entry<String, UsageInfo> cmdEntry : ADMIN_USAGE.entrySet()) {
       UsageInfo usageInfo = cmdEntry.getValue();
-      builder.append("   " + cmdEntry.getKey() + " " + usageInfo.args + "\n");
+      builder.append("   ")
+          .append(cmdEntry.getKey())
+          .append(" ")
+          .append(usageInfo.args)
+          .append("\n");
     }
-    builder.append("   -help" + " [cmd]\n");
+    builder.append("   -help [cmd]\n");
   }
 
   private static void printUsage(String cmd) {

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/SubClusterState.java

@@ -51,12 +51,8 @@ public enum SubClusterState {
   /** Subcluster has unregistered. */
   SC_UNREGISTERED;
 
-  public boolean isUnusable() {
-    return (this != SC_RUNNING && this != SC_NEW);
-  }
-
   public boolean isUsable() {
-    return !isUnusable();
+    return (this == SC_RUNNING || this == SC_NEW);
   }
 
   public boolean isActive() {

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/FederationInterceptor.java

@@ -1877,7 +1877,7 @@ private boolean isSCHealth(SubClusterId subClusterId) throws YarnException {
     Set<SubClusterId> timeOutScs = getTimedOutSCs(true);
     SubClusterInfo subClusterInfo = federationFacade.getSubCluster(subClusterId);
     if (timeOutScs.contains(subClusterId) ||
-        subClusterInfo == null || subClusterInfo.getState().isUnusable()) {
+        subClusterInfo == null || !subClusterInfo.getState().isUsable()) {
       return false;
     }
     return true;