Skip to content

Conversation

devversion
Copy link
Member

@devversion devversion commented Apr 15, 2017

  • Introduces another package called @angular/cdk. This package is
    currently empty but all the logic for SASS, HTML, TypeScript and tests
    is ready.

Note: Stuff like for the releasing is still missing. But this might be a start. Also I feel like the solution with the tests is not a perfect one. Also the logic will be simplified in a follow-up #4108

* Introduces another package called `@angular/cdk`. This package is
currently empty but all the logic for SASS, HTML, TypeScript and tests
is ready.
@devversion devversion requested a review from jelbourn April 15, 2017 17:27
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 15, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Apr 17, 2017
@jelbourn jelbourn merged commit a7ca7c1 into angular:master Apr 17, 2017
@devversion devversion deleted the build/cdk-package branch April 17, 2017 23:31
@mjamin
Copy link

mjamin commented Apr 18, 2017

Any ETA on a first release of this package and info about what it will contain?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants