Skip to content

build: remove outdated tslint rule #4121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2017

Conversation

devversion
Copy link
Member

  • At some point in tslint the no-unused-variable rule has been deprecated in favor of noUnusedLocals and noUnusedParameters. Since we don't want to have compilation errors for unused variables we re-implemented the no-unused-variable rule ourself and used it as a custom rule.

  • Recently we switched to a newer version of TSLint and TypeScript and the custom tslint rule won't ever work again. (tslint now requires a type-checker to be enabled). The custom rule fails currently and causes TSLint to not work with some editors (e.g Webstorm).

Note: TSLint un-deprecated the no-unused-variable rule again and it now requires the type-checker (and an according TypeScript project).

We are holding off with updating to the "new" no-unused-variable rule because:

@devversion devversion requested a review from jelbourn April 17, 2017 13:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 17, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Apr 17, 2017
@jelbourn
Copy link
Member

@devversion just needs rebase

* At some point in tslint the `no-unused-variable` rule has been deprecated in favor of `noUnusedLocals` and `noUnusedParameters`. Since we don't want to have compilation errors for unused variables we re-implemented the `no-unused-variable` rule ourself and used it as a custom rule.

* Recently we switched to a newer version of TSLint and TypeScript and the custom tslint rule won't ever work again. (tslint now requires a type-checker to be enabled). The custom rule fails currently and causes TSLint to not work with some editors (e.g Webstorm).
@devversion devversion force-pushed the build/remove-tslint-custom branch from 579859d to 41509ea Compare April 18, 2017 08:57
@devversion
Copy link
Member Author

@jelbourn Done.

@jelbourn jelbourn merged commit 1328307 into angular:master Apr 18, 2017
@devversion devversion deleted the build/remove-tslint-custom branch April 18, 2017 16:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants