build: remove outdated tslint rule #4121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point in tslint the
no-unused-variable
rule has been deprecated in favor ofnoUnusedLocals
andnoUnusedParameters
. Since we don't want to have compilation errors for unused variables we re-implemented theno-unused-variable
rule ourself and used it as a custom rule.Recently we switched to a newer version of TSLint and TypeScript and the custom tslint rule won't ever work again. (tslint now requires a type-checker to be enabled). The custom rule fails currently and causes TSLint to not work with some editors (e.g Webstorm).
Note: TSLint un-deprecated the
no-unused-variable
rule again and it now requires the type-checker (and an according TypeScript project).We are holding off with updating to the "new"
no-unused-variable
rule because:tsconfig.json
files inside of the whole repository.