Skip to content

Conversation

@KadelaKuba
Copy link

@KadelaKuba KadelaKuba commented Mar 3, 2023

WHY are these changes introduced?

In project was used dynamic properties that are deprecated in PHP 8.2

WHAT is this pull request doing?

This pull request adds missing properties to classess. Do not use dynamic properties. Create class properties instead.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

@KadelaKuba KadelaKuba changed the title Add support for PHP 8.2 Do not use dynamic properties in class Mar 6, 2023
@KadelaKuba KadelaKuba changed the title Do not use dynamic properties in class Do not use dynamic properties in classes Mar 6, 2023
@KadelaKuba KadelaKuba force-pushed the support-for-php-8-2 branch from 9df7678 to 853f8b6 Compare March 6, 2023 09:10
Copy link

@jDolba jDolba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easy.
We are using this fork on for a while with php 8.2 and no deprecation appearing in our error log (using only GraphQL API from PHP)

@paulomarg
Copy link
Contributor

Thanks for the contribution! We fixed this along with a couple other things in #262, so I'm going to close the PR. Please do continue to contribute in the future!

@paulomarg paulomarg closed this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants