Skip to content

Do not use dynamic properties in classes #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KadelaKuba wants to merge 2 commits into from
Closed

Do not use dynamic properties in classes #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
037038a
do not use dynamic properties - add class properties
KadelaKuba Mar 3, 2023
c0af7d2
update CHANGELOG
KadelaKuba Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## Unreleased

- [#250](https://github.com/Shopify/shopify-api-php/pull/250) [bugfix] Do not use class dynamic properties

## v4.3.0 - 2023-04-12

- [#259](https://github.com/Shopify/shopify-api-php/pull/259) Added support for 2023-04 API version, updated auto-generated REST resources
Expand Down
8 changes: 8 additions & 0 deletions src/Auth/Session.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,14 @@
*/
class Session
{
/** @var string */
private $id;
/** @var string */
private $shop;
/** @var bool */
private $isOnline;
/** @var string */
private $state;
/** @var string|null */
private $scope = null;
/** @var DateTime|null */
Expand Down