frollapply rewritten, supports by.column=F #5575
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marco Colombo <[email protected]>
28 tasks
|
Exact diff when forked from frollmax branch https://github.com/Rdatatable/data.table/compare/a14b486e4978da65c469eb39f41c19018e91f846..21da019f63947c28f9cb93fdf8f275bd52461dd5 |
|
@jangorecki would you mind marking as draft any froll-related PR which should wait for review? I assume you have a sequence in mind for when they should be merged to avoid conflicts. |
|
I think drafts make sense when new changes are expected, other then rebasing/merging to master. This PR is ready for review as much as it can, so marking it as draft takes away the chance for extra eyes looking at it. |
This was referenced May 12, 2025
10 tasks
This was referenced Aug 30, 2025
|
superseded by #7272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4887
It is forked from https://github.com/Rdatatable/data.table/tree/frollmax branch, therefore should be rebased to master once #5441 will be merged. Till then it is probably best to look at the diff here: https://github.com/Rdatatable/data.table/compare/frollmax..frollapply