Skip to content

adaptive and partial added to frollapply() #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 12, 2025
Merged

adaptive and partial added to frollapply() #6

merged 21 commits into from
May 12, 2025

Conversation

@jangorecki
Copy link
Owner

@jangorecki jangorecki commented May 12, 2025 •
edited
Loading

This PR introduces adaptive=TRUE, so as well partial=TRUE to frollapply. Fails on R < "3.4.0", fixed in next PR.

frollapply(1:3, c(1,3,3), sum, adaptive=TRUE)
#[1] 1 NA  6
frollapply(1:3, 3, sum, partial=TRUE)
#[1] 1 3 6

Yet, changes submitted in this PR has been rewritten completely in further PR.

I would therefore not try to focus here too much but rather look at the future version of frollapply: frollapply rewritten, supports by.column=F #5575
diff: https://github.com/Rdatatable/data.table/compare/frollmax..frollapply

jangorecki and others added 21 commits August 18, 2022 21:57
@jangorecki
frollmax exact, buggy fast, no fast adaptive
cca5b79
@jangorecki
frollmax fast fixing bugs
14555b2
@jangorecki
frollmax man to fix CRAN check
437b928
@jangorecki
frollmax fast adaptive non NA, dev
2fd0faf
@jangorecki
froll docs, adaptive left
6c3201a
@jangorecki
no frollmax fast adaptive
4a6f063
@jangorecki
frollmax adaptive exact NAs handling
feef63d
@jangorecki
PR summary in news
63ea485
@jangorecki
align happens in one place, less duplicated code
63f2e7d
@jangorecki
push up even more to frollR to reduce code duplication
5341409
@jangorecki
frollapply push up align arg and early stopping up
c4675be
@jangorecki @mcol
typo fix in NEWS.md
ccd5c43 
Co-authored-by: Marco Colombo <[email protected]>
@jangorecki
keep R agnostic C code in froll.c, yet deduplicated
2494b97
@jangorecki
new functionality unit tests
77a01e7
@jangorecki
doc further improving
311d12f
@jangorecki
tests and NEWS
2a54cfd
@jangorecki
partial window support for rolling functions
5a52167
@jangorecki
unit tests for partial corner cases
cab28b5
@jangorecki
frollapply adaptive
161f9f5
@jangorecki
add frollapply to timings
fc69835
@jangorecki
frollapply supports adaptive
32b04ee
MichaelChirico
MichaelChirico approved these changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jangorecki jangorecki merged commit 477e6ea into froll2025 May 12, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

@aitap aitap Awaiting requested review from aitap

@tdhock tdhock Awaiting requested review from tdhock

@TysonStanley TysonStanley Awaiting requested review from TysonStanley

@ben-schwen ben-schwen Awaiting requested review from ben-schwen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jangorecki @MichaelChirico