adapt uneven time series rolling window #5576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marco Colombo <[email protected]>
ben-schwen
reviewed
Jan 3, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Aug 30, 2023
Closed
|
There are benchmarks made on top of this branch implemented in duckdblabs/db-benchmark#9. @DorisAmoakohene may be interesed in it, steps to reproduce are at the end of the thread. |
|
This branch is forked from frollapply branch but not from its head, therefore does not include all changes made in frollapply branch, missing commits: https://github.com/Rdatatable/data.table/compare/d09651710993b6bc7ab00fb1a7e53f9361bd6db8..21da019f63947c28f9cb93fdf8f275bd52461dd5 diff vs commit where it was forked from: https://github.com/Rdatatable/data.table/compare/d09651710993b6bc7ab00fb1a7e53f9361bd6db8..319c02788d32169e1c9f26bbb59dee0012eaa5e1 |
Closed
|
superseded by #7291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3241
It is forked from https://github.com/Rdatatable/data.table/tree/frollapply branch, therefore should be rebased to master once #5575 will be merged. Till then it is probably best to look at the diff here: https://github.com/Rdatatable/data.table/compare/frollapply..adapt
As well spotted by @DavisVaughan frolladapt only supports align=right for the moment.