[16.0][MIG] bi_sql_editor (from 15.0) #670

legalsylvain · 2022-10-25T23:38:01Z

move menu and action in according view file
use new sql_request_abstract menu entry for SQL views configuration
Use sql_request_abstract primary tree view
Use sql_request_abstract primary form view
move has_grouped_changed in sql_request_abstract module
improve demo data
add default count value to display in pivot, if no pivot_measures are defined ;
set widget handle to sequence field
reorder fields in tree view and add optional hide for some fields
simplify : make field_description field required
improve : add optional='hide' and 'show' on tree visibility
Cherri-pick : [IMP] bi_sql_editor : add field context #566

Depends on #669

Description

This module extends the functionality of reporting, to support creation
of extra custom reports.
It allows user to write a custom SQL request. (Generally, admin users)

Once written, a new model is generated, and user can map the selected field
with odoo fields.
Then user ends the process, creating new menu, action and graph view.

Technically, the module create SQL View (or materialized view, if option is
checked). Materialized view duplicates datas, but request are fastest. If
materialized view is enabled, this module will create a cron task to refresh
the data).

By default, users member of 'SQL Request / User' can see all the views.
You can specify extra groups that have the right to access to a specific view.

Warning

This module is intended for technician people in a company and for Odoo integrators.

It requires the user to know SQL syntax and Odoo models.

If you don't have such skills, do not try to use this module specially on a production
environment.

Use Cases

this module is interesting for the following use cases

You want to realize technical SQL requests, that Odoo framework doesn't allow
(For exemple, UNION with many SELECT) A typical use case is if you want to have
Sale Orders and PoS Orders datas in a same table
You want to customize an Odoo report, removing some useless fields and adding
some custom ones. In that case, you can simply select the fields of the original
report (sale.report model for exemple), and add your custom fields
You have a lot of data, and classical SQL Views have very bad performance.
In that case, MATERIALIZED VIEW will be a good solution to reduce display duration

configure

Go to Dashboard / Configuration / SQL Views
tip your SQL request

Select the group(s) that could have access to the view

Optionnaly, you can add a domain.

A tipical domain in a multi company context is to write
['|', ('company_id', '=', False), ('company_id', 'in', company_ids)]
to make reporting depending on the current companies of the user.

Click on the button 'Validate SQL Expression'
Once the sql request checked, the module analyses the column of the view,
and propose field mapping. For each field, you can decide to create an index
and set if it will be displayed on the pivot graph as a column, a row or a
measure.

Click on the button 'Create SQL elements'. (this step could
take a while, if view is materialized)
If it's a MATERIALIZED view:
- a cron task is created to refresh
  the view. You can so define the frequency of the refresh.
- the size of view (and the indexes is displayed)

Finally, click on 'Create UI', to create new menu, action, graph view and
search view.

legalsylvain · 2022-10-25T23:38:25Z

/ocabot migration bi_sql_editor

OCA-git-bot · 2022-10-25T23:38:40Z

Sorry @legalsylvain you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

rvalyi · 2022-10-26T00:09:35Z

/ocabot migration bi_sql_editor

bealdav · 2022-11-23T08:44:55Z

Probably needs a rebase because of sql_request_abstract merged cc @legalsylvain

legalsylvain · 2022-11-23T09:09:50Z

/ocabot rebase

OCA-git-bot · 2022-11-23T09:09:57Z

Sorry @legalsylvain you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

bealdav · 2022-11-23T09:23:41Z

Oops @legalsylvain you probably needs to remove test-requirement.txt

legalsylvain · 2022-11-23T15:25:39Z

/ocabot rebase

OCA-git-bot · 2022-11-23T15:25:48Z

Sorry @legalsylvain you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

legalsylvain · 2022-11-23T15:33:18Z

Oops @legalsylvain you probably needs to remove test-requirement.txt

Done. CI is right. Thanks for updating your review.

bealdav

Only review in 3 last commits
Tested on runboat

Thanks a lot

florian-dacosta

Code review only
Just one remark @legalsylvain

florian-dacosta · 2022-11-25T11:26:36Z

bi_sql_editor/models/bi_sql_view_field.py

+                    "many2one_model_id": many2one_model_id,
+                }
+            )
+        return super().create(vals)


It seems quite wrong to me, should be vals_list instead of vals right ?

thanks for your review !
fixed.

legalsylvain · 2022-12-25T14:00:00Z

~~I have to cherry pick #566 (comment)~~

Edit : 01/03/2022 : done.

Ready to be merged.

[UPD] README.rst

Currently translated at 38.3% (43 of 112 strings) Translation: reporting-engine-13.0/reporting-engine-13.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-bi_sql_editor/es/

this commit allows specifying the group operator for each field. This functionality was originally included in a seperate module "bi_sql_editor_aggregate" in version 12.

On class creation by the ORM of 'manual' model, odoo now check if the table is a real table or a view to automatically set the '_auto' property on the class definition. We can therefore remove the monkey patch on 'ir.model'. see odoo/odoo@17c4f47

Currently translated at 41.0% (46 of 112 strings) Translation: reporting-engine-15.0/reporting-engine-15.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-15-0/reporting-engine-15-0-bi_sql_editor/ca/

Currently translated at 97.3% (109 of 112 strings) Translation: reporting-engine-15.0/reporting-engine-15.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-15-0/reporting-engine-15-0-bi_sql_editor/ca/

- move menu and action in according view file - use new sql_request_abstract menu entry for SQL views configuration - Use sql_request_abstract primary tree view - Use sql_request_abstract primary form view - move has_grouped_changed in sql_request_abstract module - improve demo data - add default count value to display in pivot, if no pivot_measures are defined ; - set widget handle to sequence field - reorder fields in tree view and add optional hide for some fields - simplify : make field_description field required - improve : add optional='hide' and 'show' on tree visibility - replace obsolete base.menu_board_root by spreadsheet_dashboard entries - update translation

The `table_columns()` slows down modules loading significantly up to 2-3x. In most cases `model._name.startswith(self._model_prefix)` returns `False`, so better to check it first.

OCA-git-bot · 2023-02-17T10:19:13Z

Congratulations, PR rebased to 16.0.

gurneyalex · 2023-02-17T14:43:30Z

/ocabot merge nobump

OCA-git-bot · 2023-02-17T14:43:39Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-670-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot · 2023-02-17T14:48:00Z

Congratulations, your PR was merged at ff0d4f1. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot added this to the 16.0 milestone Oct 26, 2022

OCA-git-bot mentioned this pull request Oct 26, 2022

Migration to version 16.0 #653

Open

15 tasks

legalsylvain force-pushed the 16.0-mig-bi_sql_editor branch from 1e66f6c to db5a8f6 Compare October 26, 2022 12:01

legalsylvain mentioned this pull request Oct 26, 2022

[15.0][MIG] bi_sql_editor #557

Merged

legalsylvain force-pushed the 16.0-mig-bi_sql_editor branch 3 times, most recently from 734a2d3 to 94eace5 Compare October 26, 2022 12:57

legalsylvain mentioned this pull request Oct 26, 2022

[FIX] bi_sql_editor: solves the update all break #269

Merged

legalsylvain mentioned this pull request Nov 16, 2022

[IMP] bi_sql_editor manual field check performance #683

Merged

legalsylvain force-pushed the 16.0-mig-bi_sql_editor branch from 01a614e to 61b434f Compare November 23, 2022 15:24

legalsylvain mentioned this pull request Nov 23, 2022

Maintainer are not able to merge / rebase their modules when migrating OCA/oca-github-bot#226

Open

bealdav approved these changes Nov 23, 2022

View reviewed changes

florian-dacosta suggested changes Nov 25, 2022

View reviewed changes

legalsylvain force-pushed the 16.0-mig-bi_sql_editor branch from 61b434f to 6b2bf44 Compare November 26, 2022 20:22

florian-dacosta approved these changes Nov 28, 2022

View reviewed changes

OCA-git-bot added the approved label Nov 28, 2022

kanda999 mentioned this pull request Dec 23, 2022

[2911][ADD] bi_sql_editor qrtl/fal-oca#4

Closed

legalsylvain force-pushed the 16.0-mig-bi_sql_editor branch from 47a1319 to 0705d2c Compare January 3, 2023 10:47

OCA-git-bot added the ready to merge label Jan 3, 2023

OCA-git-bot and others added 21 commits February 17, 2023 10:19

bi_sql_editor 13.0.1.0.1

a212b3d

[UPD] README.rst

Translated using Weblate (Spanish)

94d7404

Currently translated at 38.3% (43 of 112 strings) Translation: reporting-engine-13.0/reporting-engine-13.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-bi_sql_editor/es/

[IMP] bi_sql_editor: black, isort, prettier

7536779

bi_sql_editor: Migration to 14.0

24ae610

bi_sql_editor: add support for group operators

02807d7

this commit allows specifying the group operator for each field. This functionality was originally included in a seperate module "bi_sql_editor_aggregate" in version 12.

[UPD] Update bi_sql_editor.pot

ce4aafc

[UPD] README.rst

e54cce2

[IMP] bi_sql_editor: black, isort, prettier

899ff80

[MIG] bi_sql_editor: Migration to 15.0

b58ab66

[UPD] Update bi_sql_editor.pot

23731f5

[UPD] README.rst

dd45fbc

[FIX] bi_sql_editor: fix typo

7b9ea27

bi_sql_editor 15.0.1.0.1

018714d

bi_sql_editor 15.0.1.0.2

63ae51d

Translated using Weblate (Catalan)

29eb237

Currently translated at 41.0% (46 of 112 strings) Translation: reporting-engine-15.0/reporting-engine-15.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-15-0/reporting-engine-15-0-bi_sql_editor/ca/

Translated using Weblate (Catalan)

df90699

Currently translated at 97.3% (109 of 112 strings) Translation: reporting-engine-15.0/reporting-engine-15.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-15-0/reporting-engine-15-0-bi_sql_editor/ca/

[IMP] bi_sql_editor: black, isort, prettier

d62f47f

[IMP] bi_sql_editor manual field check performance

edecab1

The `table_columns()` slows down modules loading significantly up to 2-3x. In most cases `model._name.startswith(self._model_prefix)` returns `False`, so better to check it first.

[IMP] bi_sql_editor : add field context

c55dc6f

OCA-git-bot force-pushed the 16.0-mig-bi_sql_editor branch from 3372a0b to c55dc6f Compare February 17, 2023 10:19

OCA-git-bot added the bot is merging ⏳ label Feb 17, 2023

OCA-git-bot merged commit 4010f4b into OCA:16.0 Feb 17, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 17, 2023

Uh oh!

[16.0][MIG] bi_sql_editor (from 15.0) #670

[16.0][MIG] bi_sql_editor (from 15.0) #670

Uh oh!

Conversation

legalsylvain commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Warning

Use Cases

configure

Uh oh!

legalsylvain commented Oct 25, 2022

Uh oh!

OCA-git-bot commented Oct 25, 2022

Uh oh!

rvalyi commented Oct 26, 2022

Uh oh!

bealdav commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legalsylvain commented Nov 23, 2022

Uh oh!

OCA-git-bot commented Nov 23, 2022

Uh oh!

bealdav commented Nov 23, 2022

Uh oh!

legalsylvain commented Nov 23, 2022

Uh oh!

OCA-git-bot commented Nov 23, 2022

Uh oh!

legalsylvain commented Nov 23, 2022

Uh oh!

bealdav left a comment

Choose a reason for hiding this comment

Uh oh!

florian-dacosta left a comment

Choose a reason for hiding this comment

Uh oh!

florian-dacosta Nov 25, 2022

Choose a reason for hiding this comment

Uh oh!

bealdav Nov 25, 2022

Choose a reason for hiding this comment

Uh oh!

legalsylvain Nov 26, 2022

Choose a reason for hiding this comment

Uh oh!

legalsylvain commented Dec 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OCA-git-bot commented Feb 17, 2023

Uh oh!

gurneyalex commented Feb 17, 2023

Uh oh!

OCA-git-bot commented Feb 17, 2023

Uh oh!

OCA-git-bot commented Feb 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

legalsylvain commented Oct 25, 2022 •

edited

Loading

bealdav commented Nov 23, 2022 •

edited

Loading

legalsylvain commented Dec 25, 2022 •

edited

Loading