-
-
Notifications
You must be signed in to change notification settings - Fork 865
[15.0][MIG] bi_sql_editor #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ield; [ADD] security
…fresh date time on the action name of each sql materialized view
Fix error '... is not a table or foreign table' Fix view (colors + oe_highlight) Fix tests Fix README + manifest Fix back to draft Fix cron call + default values Use Postgres version 9.6 for travis builds
* [IMP] is_materialized field non readonly on sql_valid state ; [FIX] block possibility to set indexes on non materialized view * [FIX] set domain_force, group_ids readonly if state > sql_valid * [IMP] better display of the field group_ids * [IMP] possibility to reorder menu items from sql views * [IMP] Do not warn user when setting sql view to draft if state is sql_valid * [REF] * [FIX] Set Date of the first execution in the action name
[UPD] Update bi_sql_editor.pot [UPD] Update bi_sql_editor.pot [UPD] Update bi_sql_editor.pot
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
bi_sql_editor 12.0.1.1.0 [UPD] README.rst [UPD] README.rst
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-bi_sql_editor/
Currently translated at 29.1% (32 of 110 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-bi_sql_editor/de/
legalsylvain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks.
|
@mariadforgeflow. I'd like to introduce some changes / improvement / refactoring on that module. What do you prefer. do you want I make PR against your PR, or do you prefer we merge the current one, and then I propose improvment ? thanks. |
|
@legalsylvain if you want to add some improvements I think it makes more sense if we first merge this PR and then you create a new [IMP] PR. So I think we could merge this one if it's okay for you:) |
|
Ok ! I'll ping you for the review.
|
b5cffa6 to
8fa79a2
Compare
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 runbotat tests
BernatPForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@mariadforgeflow Is it ready to be merged? Can I help? |
|
@yankinmax yes it is ready! |
|
OK, merging trusting in the reviewers: /ocabot migration bi_sql_editor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 6863669. Thanks a lot for contributing to OCA. ❤️ |
|
@mariadforgeflow |
|
@CasVissers-360ERP thanks!! Fixed in #583. |
|
Hi @mariadforgeflow. I'm currently migrating I don't understand why you introduced that text in V15 : could you provide precision ? At my side, I never set that settings and it works. thanks ! |
|
Hi @legalsylvain! I didn't introduce this text, it was already there in v14 when I migrated the module. I never start odoo in command line so I don't know about this, sorry. |
|
Thanks for your answer. @davejames : could you help me on that topic ? (Ref : #518) thanks ! |
|
@legalsylvain i'm not sure, this was only committed by me during the migration, originally this was authored by @MiquelRForgeFlow |
|
;-) ! |
|
@legalsylvain was added in #269 (see #269 (comment)). |
Standard migration to v15
@ForgeFlow