Skip to content

Conversation

@mariadforgeflow
Copy link
Contributor

Standard migration to v15
@ForgeFlow

legalsylvain and others added 30 commits December 13, 2021 08:55
…fresh date time on the action name of each sql materialized view
Fix error '... is not a table or foreign table'
Fix view (colors + oe_highlight)
Fix tests
Fix README + manifest
Fix back to draft
Fix cron call + default values
Use Postgres version 9.6 for travis builds
* [IMP] is_materialized field non readonly on sql_valid state ; [FIX] block possibility to set indexes on non materialized view

* [FIX] set domain_force, group_ids readonly if state > sql_valid

* [IMP] better display of the field group_ids

* [IMP] possibility to reorder menu items from sql views

* [IMP] Do not warn user when setting sql view to draft if state is sql_valid

* [REF]

* [FIX] Set Date of the first execution in the action name
[UPD] Update bi_sql_editor.pot

[UPD] Update bi_sql_editor.pot

[UPD] Update bi_sql_editor.pot
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
bi_sql_editor 12.0.1.1.0

[UPD] README.rst

[UPD] README.rst
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-12.0/reporting-engine-12.0-bi_sql_editor
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-bi_sql_editor/
Currently translated at 29.1% (32 of 110 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-bi_sql_editor
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-bi_sql_editor/de/
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

@legalsylvain
Copy link
Contributor

@mariadforgeflow. I'd like to introduce some changes / improvement / refactoring on that module.

What do you prefer. do you want I make PR against your PR, or do you prefer we merge the current one, and then I propose improvment ?

thanks.

@mariadforgeflow
Copy link
Contributor Author

@legalsylvain if you want to add some improvements I think it makes more sense if we first merge this PR and then you create a new [IMP] PR. So I think we could merge this one if it's okay for you:)

@legalsylvain
Copy link
Contributor

Ok ! I'll ping you for the review.
Note :

  • some improvment will requires to update the installed modules.
  • I dont' have right to merge this PR.

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 runbotat tests

Copy link
Member

@BernatPForgeFlow BernatPForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yankinmax
Copy link
Contributor

@mariadforgeflow Is it ready to be merged? Can I help?

@mariadforgeflow
Copy link
Contributor Author

@yankinmax yes it is ready!
@pedrobaeza Hi! Could you please merge this? Thank you in advance.

@pedrobaeza
Copy link
Member

OK, merging trusting in the reviewers:

/ocabot migration bi_sql_editor
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 24, 2022
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-557-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jan 24, 2022
20 tasks
@OCA-git-bot OCA-git-bot merged commit 9737a60 into OCA:15.0 Jan 24, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6863669. Thanks a lot for contributing to OCA. ❤️

@CasVissers-360ERP
Copy link

@mariadforgeflow
I think you made a typo while migrating the module:
index_name = fields.Char(ompute="_compute_index_name")

@mariadforgeflow mariadforgeflow deleted the 15-mig-bi_sql_editor branch February 1, 2022 07:47
@mariadforgeflow
Copy link
Contributor Author

@CasVissers-360ERP thanks!! Fixed in #583.

@legalsylvain
Copy link
Contributor

legalsylvain commented Oct 26, 2022

Hi @mariadforgeflow. I'm currently migrating bi_sql_editor in V16. (see : #670)

I don't understand why you introduced that text in V15 :

* You must put this module as `server_wide_modules` in your odoo configuration file
  or add '--load=bi_sql_editor' if you start odoo in command line.

could you provide precision ? At my side, I never set that settings and it works.

thanks !

@mariadforgeflow
Copy link
Contributor Author

Hi @legalsylvain! I didn't introduce this text, it was already there in v14 when I migrated the module.
I checked and it was added here: bf96a35

I never start odoo in command line so I don't know about this, sorry.

@legalsylvain
Copy link
Contributor

legalsylvain commented Oct 26, 2022

Thanks for your answer. @davejames : could you help me on that topic ?

(Ref : #518)

thanks !

@davejames
Copy link
Member

@legalsylvain i'm not sure, this was only committed by me during the migration, originally this was authored by @MiquelRForgeFlow

@legalsylvain
Copy link
Contributor

;-) !
OK ! @MiquelRForgeFlow : any idea ?

@MiquelRForgeFlow
Copy link
Contributor

MiquelRForgeFlow commented Oct 26, 2022

@legalsylvain was added in #269 (see #269 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.