[16.0][MIG] sql_request_abstract

[legalsylvain]

• Add new main entry menu for SQL configuration
• Add abstract tree view
• Add abstract form view
• ADD ace/mode-pgsql.js file to have syntaxic coloration in sql field
• move has_grouped_changed from bi_sql_editor to sql_request_abstract

Note

indroduce ace for postgresql looks great ! See

Description

This module provides an abstract model to manage SQL Select requests on database.
It is not usefull for itself. You can see an exemple of implementation in the
'sql_export' module. (same repository).

Implemented features

• Add some restrictions in the sql request:

  • you can only read datas. No update, deletion or creation are possible.
  • some tables are not allowed, because they could contains clear password
    or keys. For the time being ('ir_config_parameter').

• The request can be in a 'draft' or a 'SQL Valid' status. To be valid,
  the request has to be cleaned, checked and tested. All of this operations
  can be disabled in the inherited modules.

• This module two new groups:

  • SQL Request / User : Can see all the sql requests by default and execute
    them, if they are valid.
  • SQL Request / Manager : has full access on sql requests.

DEVELOP

Inherit the model:

    from odoo import models

    class MyModel(models.model)
        _name = 'my.model'
        _inherit = ['sql.request.mixin']

        _sql_request_groups_relation = 'my_model_groups_rel'

        _sql_request_users_relation = 'my_model_users_rel'

See implementations in the modules bi_sql_editor and sql_export. (same OCA/reporting-engine repository)

[sebastienbeau]

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-669-by-sebastienbeau-bump-patch, awaiting test results.

[OCA-git-bot]

@sebastienbeau your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-669-by-sebastienbeau-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[OCA-git-bot]

@sebastienbeau your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-669-by-sebastienbeau-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[bealdav]

I don't know why merge fails ? Error seems suggest than codecov needs to be green to be successful.
I thought that green codecov wasn't mandatory !?
Anybody know about this kind of things ?
cc @legalsylvain @sebastienbeau @sbidoul Thanks

[sbidoul]

@bealdav follow this path:

Conclusion: need to run pipx run copier -f update.

[legalsylvain]

/ocabot rebase

[OCA-git-bot]

Sorry @legalsylvain you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

[sbidoul]

@legalsylvain if the issue is fixed on the main branch, a rebase should not be necessary as the merge command merges before running the tests.

[bealdav]

OK that's https://gitlab.com/PyCQA/flake8 close repository that Pedro mention on twitter.
Sorry @sbidoul for the noise I've just look into commit "[[MIG] sql_request_abstract from 15.0 to 16.0]" not the "[[UPD] Update sql_request_abstract.pot" because the last one is automatic.

Maybe needs a copier update to apply settings to the repo ?

[bealdav]

Now fixed OCA/pylint-odoo#446

[bealdav]

Please @HviorForgeFlow @faide @etobella could you give a new try to get PR merged. Thanks

[etobella]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-669-by-etobella-bump-nobump, awaiting test results.

[OCA-git-bot]

@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-669-by-etobella-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[etobella]

Prolem with the flake8-calypse. IT should be fixed now 🙏

/ocabot merge nobump

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-669-by-etobella-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 705585d. Thanks a lot for contributing to OCA. ❤️