Parse popovers for footnotes #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the migration to bootstrap-vue, popovers had to be parsed into bootstrap-vue syntax. This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there. Let's add the parsing of popovers to the footnotes plugin to solve this.
le0tan
added
c.Bug 🐛
p.Medium
pr.BugFix 🐛
nbriannl
reviewed
Mar 29, 2020
| you don't have to pick an identifier and move down to type the | ||
| note.</p> | ||
| </div> | ||
| </span> |
Contributor
There was a problem hiding this comment.
weird that the indents are incorrect, but i assume this is what updatetest generated, so can't really argue with this, can I?
yamgent
approved these changes
Apr 5, 2020
Member
|
@openorclose resolve conflicts |
…vers # Conflicts: # test/functional/test_site/expected/index.html
Contributor
Author
Done! |
This was referenced Apr 5, 2020
Tejas2805
added a commit
to Tejas2805/markbind
that referenced
this pull request
Apr 9, 2020
* 'master' of https://github.com/MarkBind/markbind: (41 commits) Document adding new site content in DG (MarkBind#1153) Add relative date feature (MarkBind#908) Use <br> to separate lines of code block (MarkBind#1176) Parse popovers for footnotes (MarkBind#1155) Resolve comments Expand test extensions and fix whitespace checks (MarkBind#1156) Address comments Upgrade js-beautify and provide option to turn it off (MarkBind#1116) Normalize inline puml line ending before hashing (MarkBind#1174) Update tests (MarkBind#1178) Remove fixed bugs from test\functional\test_site\bugs\index.md` (MarkBind#1148) Fix bug in Search for UG and DG (MarkBind#1147) Add inline puml support (MarkBind#1100) Fix hrefs for headings with angular brackets (MarkBind#1089) Update tests for 2.13.1 (MarkBind#1169) 2.13.1 Update vue-strap version to v2.0.1-markbind.39 Fix fontawsome icons don't show underlines to indicate modal/tooltip (MarkBind#1133) 2.13.0 Update test files ...
marvinchin
pushed a commit
that referenced
this pull request
Apr 10, 2020
During the migration to bootstrap-vue, popovers had to be parsed into bootstrap-vue syntax. This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there. Let's add the parsing of popovers to the footnotes plugin to solve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
What is the rationale for this request?
Fixes #1154
What changes did you make? (Give an overview)
Specifically called the componentParser on the
popovers in the footnotes pluginProvide some example code that this change will affect:
Is there anything you'd like reviewers to focus on?
This is the simple bug fix for now. Long term solution to fix footnotes inside dynamic panels is still in the works.
Testing instructions:
Check that the popovers appear.
Proposed commit message: (wrap lines at 72 characters)