Skip to content

Conversation

@nbriannl
Copy link
Contributor

@nbriannl nbriannl commented Apr 3, 2020

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [ ] Documentation update
• [ ] Bug fix
• [ ] New feature
• [ ] Enhancement to an existing feature
• [X] Other, please explain: Update tests due to wrong versioning

What is the rationale for this request?

What changes did you make? (Give an overview)

Provide some example code that this change will affect:

Is there anything you'd like reviewers to focus on?

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Update tests

Build is failing for commit 7ec7bc4 due to outdated versioning
Let us update tests

@nbriannl nbriannl requested a review from marvinchin April 3, 2020 05:24
@marvinchin marvinchin added this to the v2.13.2 milestone Apr 3, 2020
@marvinchin marvinchin merged commit 0e91dc2 into MarkBind:master Apr 3, 2020
Tejas2805 added a commit to Tejas2805/markbind that referenced this pull request Apr 9, 2020
* 'master' of https://github.com/MarkBind/markbind: (41 commits)
  Document adding new site content in DG (MarkBind#1153)
  Add relative date feature (MarkBind#908)
  Use <br> to separate lines of code block (MarkBind#1176)
  Parse popovers for footnotes (MarkBind#1155)
  Resolve comments
  Expand test extensions and fix whitespace checks (MarkBind#1156)
  Address comments
  Upgrade js-beautify and provide option to turn it off (MarkBind#1116)
  Normalize inline puml line ending before hashing (MarkBind#1174)
  Update tests (MarkBind#1178)
  Remove fixed bugs from test\functional\test_site\bugs\index.md` (MarkBind#1148)
  Fix bug in Search for UG and DG (MarkBind#1147)
  Add inline puml support (MarkBind#1100)
  Fix hrefs for headings with angular brackets (MarkBind#1089)
  Update tests for 2.13.1 (MarkBind#1169)
  2.13.1
  Update vue-strap version to v2.0.1-markbind.39
  Fix fontawsome icons don't show underlines to indicate modal/tooltip (MarkBind#1133)
  2.13.0
  Update test files
  ...
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
Build is failing for commit 7ec7bc4 due to outdated versioning
Let us update tests
@nbriannl nbriannl deleted the update-test-3-4-2020 branch April 16, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants