Skip to content

Parse popovers for footnotes #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yamgent merged 2 commits into from
Apr 7, 2020
Merged

Parse popovers for footnotes #1155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65a9233
Parse popovers for footnotes
openorclose Mar 28, 2020
07e21c0
Merge remote-tracking branch 'origin/master' into parse_footnote_popo…
openorclose Apr 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/plugins/default/markbind-plugin-footnotes-popovers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const cheerio = module.parent.require('cheerio');
const { parseComponents } = require('../../lib/markbind/src/parsers/componentParser.js');

module.exports = {
postRender: (content) => {
Expand All @@ -17,6 +18,9 @@ module.exports = {
$('#content-wrapper')
.append($('hr.footnotes-sep'))
.append($('section.footnotes').append(popoversHtml));
$('section.footnotes popover').each((index, popover) => {
parseComponents(popover);
});
return $.html();
},
};
18 changes: 9 additions & 9 deletions test/functional/test_site/expected/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,27 +646,27 @@ <h6 class="always-index" id="level-6-header-outside-headingsearchindex-with-alwa
note.</p>
</li>
</ol>
<popover id="pop:footnote1">
<div slot="content">
<span id="pop:footnote1" data-mb-component-type="popover" v-b-popover.hover.top.html="popoverInnerGenerator" class="trigger">
<div data-mb-html-for="content">
<p>Here is the footnote. Footnotes will appear at the bottom of the page.</p>
</div>
</popover>
</span>

<popover id="pop:footnote2">
<div slot="content">
<span id="pop:footnote2" data-mb-component-type="popover" v-b-popover.hover.top.html="popoverInnerGenerator" class="trigger">
<div data-mb-html-for="content">
<p>Here's one with multiple blocks.</p>
<p>Subsequent paragraphs are indented to show that they
belong to the previous footnote.</p>
</div>
</popover>
</span>

<popover id="pop:footnote3">
<div slot="content">
<span id="pop:footnote3" data-mb-component-type="popover" v-b-popover.hover.top.html="popoverInnerGenerator" class="trigger">
<div data-mb-html-for="content">
<p>Inlines notes are easier to write, since
you don't have to pick an identifier and move down to type the
note.</p>
</div>
</popover>
</span>
</section>
</div>

Expand Down