Bulk gcore cleanup, replace core and alloc with std
#2735
Conversation
Firestar99
force-pushed
the
gcore_bulk_cleanup
branch
from
2cce1db to
c45bb3d
Compare
Firestar99
force-pushed
the
gcore_feature_removal
branch
from
1164fd1 to
1a3d5d8
Compare
Keavon
force-pushed
the
master
branch
2 times, most recently
from
34dced3 to
5cacab2
Compare
Keavon
force-pushed
the
gcore_bulk_cleanup
branch
from
c45bb3d to
1f5554f
Compare
| pub(crate) footprint: Option<&'a crate::transform::Footprint>, | ||
| pub(crate) footprint: Option<&'a Footprint>, | ||
| varargs: Option<&'a [DynRef<'a>]>, | ||
| // This could be converted into a single enum to save extra bytes |
There was a problem hiding this comment.
Only the owned context should be moved out of the context file, the rest should if possible remain no std
There was a problem hiding this comment.
Your comment confuses me. This PR doesn't move anything, it just changes the paths to symbols for things within the crate, to make all the absolute paths and use statements use std instead of core or alloc. I'll start extracting a no_std crate gcore_types out of the gcore crate in some later PR, yet to be submitted. And can change all the symbols back to core, as required.
There was a problem hiding this comment.
This is basically a future note to you that you will need to split this file into two versions, one which uses std (and containts the OwnedContextImpl) and a second one which contains the rest so you'll have to change the paths you've converted to std in this file for this pr back to core
There was a problem hiding this comment.
I thought it was a change request and was confused at what you wanted to have changed. All good if it was just a note :D
…Editor#2735) * gcore: replace `core` and `alloc` paths with `std` * node-graph: remove unnecessary path prefix * gcore: remove most `#[cfg(target_arch = "spirv")]`, keep some potentially useful ones --------- Co-authored-by: Keavon Chambers <[email protected]>
Requires #2724
This PR contains the bulk renames, for code changes see #2724