Unify feature dependencies with workspace dependencies #2736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
changed the title
Firestar99
changed the title
Firestar99
changed the title
Keavon
force-pushed
the
workspace-dependencies
branch
from
da125b8 to
0c0551f
Compare
Keavon
force-pushed
the
gcore_bulk_cleanup
branch
from
c45bb3d to
1f5554f
Compare
TrueDoctor
approved these changes
Jun 21, 2025
Keavon
force-pushed
the
workspace-dependencies
branch
from
0c0551f to
cb8a6c3
Compare
Keavon
changed the title
urisinger
pushed a commit
to urisinger/Graphite
that referenced
this pull request
Jul 15, 2025
…r#2736) * graph-craft: fix direct wasm build * graph-craft: fix no serde feature failing to compile * graph-craft: make wgpu-executor properly optional * workspace: unify `image` formats in workspace * workspace: turn most dependencies into workspace deps, no actual changes * workspace: unify dependency features in workspace dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #2735
Every crate currently defines their own features, which means if you build or check an intermediary crate, and that one doesn't need eg.
web_sys/TextMetrics(fromgraphite-wasm),web_syswill be recompiled. That including all it's dependents, likewgpu,gcoreand pretty much every single crate in this repo. This makes it super annoying to build or check different crates in the tree. So I unified all features in the workspaceCargo.toml.Sure, usually you only use
graphene-cliorgraphite-wasmas the main targets, but I've noticed it quite a bit. Also simplifies all active features of a crate to a single location, instead of all over the codebase. Which helps me later when I don't have to think about features when refactoring.