Make gcore a std library and remove std, alloc, and more unused features (#2724)

* gcore: remove features `std`, `alloc`, `gpu` and `reflections`, now always available

* gcore: remove non-working features `kurbo` and `log`

Author: Firestar99

Cargo.lock

@@ -15,7 +15,6 @@ default = ["wasm"]
 wasm = ["wasm-bindgen", "graphene-std/wasm", "wasm-bindgen-futures"]
 gpu = [
 	"interpreted-executor/gpu",
-	"graphene-std/gpu",
 	"wgpu-executor",
 ]
 tauri = ["ron", "decouple-execution"]

editor/Cargo.toml

@@ -1161,13 +1161,6 @@ pub(crate) fn selective_color_properties(node_id: NodeId, context: &mut NodeProp
 	]
 }
 
-#[cfg(feature = "gpu")]
-pub(crate) fn _gpu_map_properties(parameter_widgets_info: ParameterWidgetsInfo) -> Vec<LayoutGroup> {
-	let map = text_widget(parameter_widgets_info);
-
-	vec![LayoutGroup::Row { widgets: map }]
-}
-
 pub(crate) fn grid_properties(node_id: NodeId, context: &mut NodePropertiesContext) -> Vec<LayoutGroup> {
 	let grid_type_index = grid::GridTypeInput::INDEX;
 	let spacing_index = grid::SpacingInput::<f64>::INDEX;

editor/src/messages/portfolio/document/node_graph/node_properties.rs

@@ -29,7 +29,7 @@ editor = { path = "../../editor", package = "graphite-editor", features = [
 # Workspace dependencies
 graph-craft = { workspace = true }
 log = { workspace = true }
-graphene-core = { workspace = true, features = ["std", "alloc"] }
+graphene-core = { workspace = true }
 serde = { workspace = true, features = ["derive"] }
 wasm-bindgen = { workspace = true }
 serde-wasm-bindgen = { workspace = true }

frontend/wasm/Cargo.toml

@@ -7,28 +7,13 @@ authors = ["Graphite Authors <[email protected]>"]
 license = "MIT OR Apache-2.0"
 
 [features]
-default = ["serde", "kurbo", "log", "std", "rand_chacha", "wasm"]
-log = ["dep:log"]
-gpu = ["spirv-std", "glam/bytemuck", "dyn-any", "glam/libm"]
+default = ["serde", "wasm"]
 nightly = []
-alloc = ["dyn-any", "bezier-rs"]
 type_id_logging = []
 wasm = ["web-sys"]
 wgpu = ["dep:wgpu"]
 vello = ["dep:vello", "bezier-rs/kurbo", "wgpu"]
-dealloc_nodes = ["reflections"]
-std = [
-	"dyn-any",
-	"dyn-any/std",
-	"alloc",
-	"glam/std",
-	"specta",
-	"num-traits/std",
-	"rustybuzz",
-	"image",
-	"reflections",
-]
-reflections = ["alloc", "ctor"]
+dealloc_nodes = []
 serde = [
 	"dep:serde",
 	"glam/serde",
@@ -55,31 +40,30 @@ petgraph = { workspace = true, default-features = false, features = [
 ] }
 rustc-hash = { workspace = true }
 math-parser = { path = "../../libraries/math-parser" }
+dyn-any = { workspace = true }
+ctor = { workspace = true }
+rand_chacha = { workspace = true }
+bezier-rs = { workspace = true }
+specta = { workspace = true }
+rustybuzz = { workspace = true }
+image = { workspace = true, default-features = false, features = [
+	"png",
+] }
 
 # Required dependencies
 half = { version = "2.4.1", default-features = false, features = ["bytemuck"] }
 tinyvec = { version = "1" }
+kurbo = { workspace = true }
+log = { workspace = true }
 
 # Optional workspace dependencies
-dyn-any = { workspace = true, optional = true }
-spirv-std = { workspace = true, optional = true }
 serde = { workspace = true, optional = true, features = ["derive"] }
-ctor = { workspace = true, optional = true }
-log = { workspace = true, optional = true }
-rand_chacha = { workspace = true, optional = true }
-bezier-rs = { workspace = true, optional = true }
-kurbo = { workspace = true, optional = true }
 base64 = { workspace = true, optional = true }
 vello = { workspace = true, optional = true }
 wgpu = { workspace = true, optional = true }
-specta = { workspace = true, optional = true }
-rustybuzz = { workspace = true, optional = true }
 web-sys = { workspace = true, optional = true, features = [
 	"HtmlCanvasElement",
 ] }
-image = { workspace = true, optional = true, default-features = false, features = [
-	"png",
-] }
 
 [dev-dependencies]
 # Workspace dependencies

node-graph/gcore/Cargo.toml

@@ -36,7 +36,6 @@ impl Hash for SurfaceFrame {
 	}
 }
 
-#[cfg(feature = "dyn-any")]
 unsafe impl StaticType for SurfaceFrame {
 	type Static = SurfaceFrame;
 }
@@ -52,8 +51,6 @@ impl Size for web_sys::HtmlCanvasElement {
 	}
 }
 
-// pub type TextureDataTable = Instances<ImageTexture>;
-
 #[derive(Debug, Clone)]
 pub struct ImageTexture {
 	#[cfg(feature = "wgpu")]
@@ -84,7 +81,6 @@ impl PartialEq for ImageTexture {
 	}
 }
 
-#[cfg(feature = "dyn-any")]
 unsafe impl StaticType for ImageTexture {
 	type Static = ImageTexture;
 }
@@ -123,7 +119,6 @@ impl<S: Size> Size for SurfaceHandle<S> {
 	}
 }
 
-#[cfg(feature = "dyn-any")]
 unsafe impl<T: 'static> StaticType for SurfaceHandle<T> {
 	type Static = SurfaceHandle<T>;
 }
@@ -134,7 +129,6 @@ pub struct SurfaceHandleFrame<Surface> {
 	pub transform: DAffine2,
 }
 
-#[cfg(feature = "dyn-any")]
 unsafe impl<T: 'static> StaticType for SurfaceHandleFrame<T> {
 	type Static = SurfaceHandleFrame<T>;
 }
@@ -309,7 +303,6 @@ impl<T> Debug for EditorApi<T> {
 	}
 }
 
-#[cfg(feature = "dyn-any")]
 unsafe impl<T: StaticTypeSized> StaticType for EditorApi<T> {
 	type Static = EditorApi<T::Static>;
 }

node-graph/gcore/src/application_io.rs

@@ -243,38 +243,6 @@ impl GraphicElement {
 	}
 }
 
-// // TODO: Rename to Raster
-// #[derive(Clone, Debug, Hash, PartialEq, DynAny)]
-// pub enum RasterDataType {
-// 	/// A CPU-based bitmap image with a finite position and extent, equivalent to the SVG <image> tag: https://developer.mozilla.org/en-US/docs/Web/SVG/Element/image
-// 	// TODO: Rename to ImageTable
-// 	RasterData(RasterDataTable<CPU>),
-// 	/// A GPU texture with a finite position and extent
-// 	// TODO: Rename to ImageTextureTable
-// 	TextureData(TextureDataTable),
-// }
-
-// impl<'de> serde::Deserialize<'de> for RasterDataType {
-// 	fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
-// 	where
-// 		D: serde::Deserializer<'de>,
-// 	{
-// 		Ok(RasterDataType::RasterData(RasterDataTable::new(Image::deserialize(deserializer)?)))
-// 	}
-// }
-
-// impl serde::Serialize for RasterDataType {
-// 	fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
-// 	where
-// 		S: serde::Serializer,
-// 	{
-// 		match self {
-// 			RasterDataType::RasterData(_) => self.serialize(serializer),
-// 			RasterDataType::TextureData(_) => todo!(),
-// 		}
-// 	}
-// }
-
 impl<'de> serde::Deserialize<'de> for Raster<CPU> {
 	fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
 	where

node-graph/gcore/src/gpu.rs

@@ -142,7 +142,6 @@ impl<T: PartialEq> PartialEq for Instances<T> {
 	}
 }
 
-#[cfg(feature = "dyn-any")]
 unsafe impl<T: StaticType + 'static> StaticType for Instances<T> {
 	type Static = Instances<T>;
 }