Skip to content

Conversation

@ddeboer
Copy link
Member

@ddeboer ddeboer commented Aug 12, 2014

Fix #117.

I think this makes sense, but @dbu, please validate whether this answers to a proper use case (#117).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also say that you should only use this when the header varies. if its always the same (e.g. a basic authentication or similar), you should just pass in a guzzle client configured to send that header, rather than spread the logic throughout the code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a section to the docs.

@dbu
Copy link
Contributor

dbu commented Aug 12, 2014

i think its consistent to do this as we have it for refresh.

its a special case - the more common case of always having to send some headers (to authenticate or such) should be handled by passing a custom guzzle client.

@ddeboer
Copy link
Member Author

ddeboer commented Aug 12, 2014

Added doc section. As this doesn’t break BC – optional interface method arguments can be left out of implementations (nice one, PHP) – this can be safely merged.

@dbu
Copy link
Contributor

dbu commented Aug 12, 2014

are you sure? i thought php complains about that. but well, we are still RC so its like last moment ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the link really work like this? don't you need the filename in <>?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbu it is a ref to the line 182 in this file.

dbu added a commit that referenced this pull request Aug 12, 2014
@dbu dbu merged commit 80f145c into master Aug 12, 2014
@dbu dbu deleted the purge-headers branch August 12, 2014 11:22
@dbu
Copy link
Contributor

dbu commented Aug 12, 2014

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to send headers with Purge request (Varnish)

5 participants