-
Notifications
You must be signed in to change notification settings - Fork 61
Add optional headers to purge call #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -103,6 +103,21 @@ path:: | |
| ->flush() | ||
| ; | ||
|
|
||
| You can specify HTTP headers as the second argument to ``purge()``. | ||
| For instance:: | ||
|
|
||
| $client | ||
| ->purge('/some/path', array('X-Foo' => 'bar') | ||
| ->flush() | ||
| ; | ||
|
|
||
| Please note that purge will invalidate all variants, so you do not have to | ||
| send any headers that you vary on, such as ``Accept``. | ||
|
|
||
| The above allows you to pass headers that are different between purge requests. | ||
| If you want to send headers for all purge requests, such as ``Authorization``, | ||
| use a :ref:`custom Guzzle client <custom Guzzle client>` instead. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does the link really work like this? don't you need the filename in
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dbu it is a ref to the line 182 in this file. |
||
|
|
||
| Refresh | ||
| ~~~~~~~ | ||
|
|
||
|
|
@@ -163,3 +178,23 @@ Varnish client:: | |
|
|
||
| Make sure to add any headers that you want to ban on to your | ||
| :doc:`Varnish configuration <varnish-configuration>`. | ||
|
|
||
| .. _custom guzzle client: | ||
|
|
||
| Custom Guzzle Client | ||
| -------------------- | ||
|
|
||
| By default, the proxy clients instantiate a `Guzzle client`_ to communicate | ||
| with the caching proxy. If you need to customize the requests, for example to | ||
| send a basic authentication header, you can inject a custom Guzzle client:: | ||
|
|
||
| use FOS\HttpCache\ProxyClient\Varnish; | ||
| use Guzzle\Http\Client; | ||
|
|
||
| $client = new Client(); | ||
| $client->setDefaultOption('auth', array('username', 'password', 'Digest')); | ||
|
|
||
| $servers = array('10.0.0.1'); | ||
| $varnish = new Varnish($servers, '/baseUrl', $client); | ||
|
|
||
| .. _Guzzle client: http://guzzle3.readthedocs.org/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also say that you should only use this when the header varies. if its always the same (e.g. a basic authentication or similar), you should just pass in a guzzle client configured to send that header, rather than spread the logic throughout the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a section to the docs.