Unable to send headers with Purge request (Varnish)

[calumbrodie]

Currently the purge mechanism does not allow headers to be sent with the request?

My use case is that my hash for my page uses cookies as part of the hash, and unless I send these with the purge request, it doesn't target the right hash, and won't purge the content from varnish.

[ddeboer]

You’re right: it’s currently not possible to send headers along with the purge request. As this is possible for refresh, I think this is an oversight, so I’m going to add it right away.

[dbu]

@calumbrodie and fixed. note the note we added: if its a general header that is always the same, do a custom guzzle client rather than send that header from all calls to purge

[calumbrodie]

@dbu @ddeboer Thanks both for the quick response on this. As you suspected the header is general and will be required for all purge requests so I'll implement it via a custom guzzle client as you suggest (thanks for the suggestion)

Wondering if this change requires updating the CacheManager in the Symfony bundle too. https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/blob/master/CacheManager.php

[dbu]

the CacheManager methods do not accept custom headers. but it would
probably make sense to also do it. and
https://github.com/FriendsOfSymfony/FOSHttpCache/blob/master/src/CacheInvalidator.php
has the same inconsistency with headers for refreshPath but not for
invalidatePath.

@calumbrodie do you want to do a pull request to fix this?

[calumbrodie]

Yes - I'll do it this evening

[dbu]

great!