🐛 Fix finding_group view #13119
🐛 Fix finding_group view #13119
Conversation
🔴 Risk threshold exceeded.This pull request modifies a sensitive file (dojo/finding_group/views.py) and was flagged twice by the scanner as "Configured Codepaths Edit" (sensitive edits detected); the finding lists a risk threshold of "failing" but is not blocking, and allowed authors/sensitive paths can be configured in .dryrunsecurity.yaml.
🔴 Configured Codepaths Edit in
|
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
🔴 Configured Codepaths Edit in dojo/finding_group/views.py
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
We've notified @mtesauro.
All finding details can be found in the DryRun Security Dashboard.
|
Thanks. Does this mean we lack some pageviews in the integration tests? |
I have no clue, just ran into this error. Might be |
|
Is it an error or warning as I am unable to reproduce it. |
|
added some basic UI tests. the ruff stuff should be fixed soon on the bugfix branch. |
valentijnscholten
force-pushed
the
fix_finding_group
branch
from
c5acba6 to
2f9d78d
Compare
|
It was an error. You can reproduce it, if you setup a new DefectDojo (docker system prune and docker volume prune) |
|
Just reproduced it again: |
uwsgi-1 | File "/app/dojo/finding_group/views.py", line 288, in paginate_queryset
uwsgi-1 | paginator = Paginator(queryset, page_size)
uwsgi-1 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
uwsgi-1 | File "/usr/local/lib/python3.11/site-packages/django/core/paginator.py", line 46, in init
uwsgi-1 | self._check_object_list_is_ordered()
uwsgi-1 | File "/usr/local/lib/python3.11/site-packages/django/core/paginator.py", line 142, in _check_object_list_is_ordered
uwsgi-1 | warnings.warn(
uwsgi-1 | django.core.paginator.UnorderedObjectListWarning: Pagination may yield inconsistent results with an unordered object_list: <class 'dojo.models.Finding_Group'> QuerySet.