🐛 Fix finding_group view (#13119)

* 🐛 Fix finding_group view

* ruff

* finding group view: add basic UI tests

---------

Co-authored-by: Valentijn Scholten <[email protected]>

Author: manuel-sommer

dojo/finding_group/views.py

@@ -285,6 +285,7 @@ def get_finding_groups(self, request: HttpRequest, products: QuerySet[Product] |
 
     def paginate_queryset(self, queryset: QuerySet[Finding_Group], request: HttpRequest) -> Page:
         page_size = int(request.GET.get("page_size", 25))
+        queryset = queryset.order_by("id")
         paginator = Paginator(queryset, page_size)
         page_number = request.GET.get("page")
         return paginator.get_page(page_number)

tests/check_various_pages.py

@@ -16,12 +16,32 @@ def test_calendar_status(self):
         # click apply to see if this helps webdriver to catch the javascript errors we're seeing
         driver.find_element(By.CSS_SELECTOR, "input.btn.btn-primary").click()
 
+    def test_finding_group_open_status(self):
+        driver = self.driver
+        driver.get(self.base_url + "finding_group/open")
+
+    def test_finding_group_all_status(self):
+        driver = self.driver
+        driver.get(self.base_url + "finding_group/all")
+
+    def test_finding_group_closed_status(self):
+        driver = self.driver
+        driver.get(self.base_url + "finding_group/closed")
+
+    def test_finding_group_open_filtered_status(self):
+        driver = self.driver
+        driver.get(self.base_url + "finding_group/open?name=CVE&severity=Medium&engagement=14&product=6")
+
 
 def suite():
     suite = unittest.TestSuite()
     suite.addTest(BaseTestCase("test_login"))
     suite.addTest(VariousPagesTest("test_user_status"))
     suite.addTest(VariousPagesTest("test_calendar_status"))
+    suite.addTest(VariousPagesTest("test_finding_group_open_status"))
+    suite.addTest(VariousPagesTest("test_finding_group_all_status"))
+    suite.addTest(VariousPagesTest("test_finding_group_closed_status"))
+    suite.addTest(VariousPagesTest("test_finding_group_open_filtered_status"))
     return suite