Skip to content

🐛 Fix finding_group view #13119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2025
Merged

🐛 Fix finding_group view #13119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e7a5c9
:bug: Fix finding_group view
manuel-sommer Sep 5, 2025
bf36d58
ruff
manuel-sommer Sep 5, 2025
2f9d78d
finding group view: add basic UI tests
valentijnscholten Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dojo/finding_group/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ def get_finding_groups(self, request: HttpRequest, products: QuerySet[Product] |

def paginate_queryset(self, queryset: QuerySet[Finding_Group], request: HttpRequest) -> Page:
page_size = int(request.GET.get("page_size", 25))
queryset = queryset.order_by("id")
paginator = Paginator(queryset, page_size)
page_number = request.GET.get("page")
return paginator.get_page(page_number)
Expand Down
20 changes: 20 additions & 0 deletions tests/check_various_pages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,32 @@ def test_calendar_status(self):
# click apply to see if this helps webdriver to catch the javascript errors we're seeing
driver.find_element(By.CSS_SELECTOR, "input.btn.btn-primary").click()

def test_finding_group_open_status(self):
driver = self.driver
driver.get(self.base_url + "finding_group/open")

def test_finding_group_all_status(self):
driver = self.driver
driver.get(self.base_url + "finding_group/all")

def test_finding_group_closed_status(self):
driver = self.driver
driver.get(self.base_url + "finding_group/closed")

def test_finding_group_open_filtered_status(self):
driver = self.driver
driver.get(self.base_url + "finding_group/open?name=CVE&severity=Medium&engagement=14&product=6")


def suite():
suite = unittest.TestSuite()
suite.addTest(BaseTestCase("test_login"))
suite.addTest(VariousPagesTest("test_user_status"))
suite.addTest(VariousPagesTest("test_calendar_status"))
suite.addTest(VariousPagesTest("test_finding_group_open_status"))
suite.addTest(VariousPagesTest("test_finding_group_all_status"))
suite.addTest(VariousPagesTest("test_finding_group_closed_status"))
suite.addTest(VariousPagesTest("test_finding_group_open_filtered_status"))
return suite


Expand Down