Skip to content

Conversation

@seantleonard
Copy link
Contributor

@seantleonard seantleonard commented May 13, 2024

Why make this change?

What is this change?

  • For .net6 updates npgsql to 7.0.7.
  • Removes "ignore" tag on serialization/deserialization test that broke because of the npgsql version used.

How was this tested?

  • Unit Tests
    • dotnet format step passes without dotnet restore vulnerability alert.
    • unit test TestDictionaryDatabaseObjectSerializationDeserialization unignored

… alert no longer shows due to correct patched versions being recognized by dotnet restore.
Copy link
Contributor

@aaronburtle aaronburtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@seantleonard
Copy link
Contributor Author

/azp run

@seantleonard seantleonard enabled auto-merge (squash) May 14, 2024 01:04
@seantleonard
Copy link
Contributor Author

/azp run

@seantleonard seantleonard merged commit da16701 into main May 14, 2024
@seantleonard seantleonard deleted the dev/sean/1.1_npgsql_patch branch May 14, 2024 02:20
ayush3797 pushed a commit that referenced this pull request May 14, 2024
## Why make this change?

- Closes #2206
- As noted in #2207, now that false positive vulnerability alert no
longer shows due to correct patched versions being recognized by dotnet
restore.
- Merging Directory to 1.1 branch.

## What is this change?

- For .net6 updates npgsql to 7.0.7.
- Removes "ignore" tag on serialization/deserialization test that broke
because of the npgsql version used.

## How was this tested?
- [x] Unit Tests 
- `dotnet format` step passes without dotnet restore vulnerability
alert.
- unit test `TestDictionaryDatabaseObjectSerializationDeserialization`
unignored
ayush3797 added a commit that referenced this pull request May 14, 2024
## Why make this change?
Ports bug-fixes to release/1.1:

1.) #2214
2.) #2215
3.) #2208
4.) #2216

---------

Co-authored-by: Yogi K <[email protected]>
Co-authored-by: Aniruddh Munde <[email protected]>
Co-authored-by: Sean Leonard <[email protected]>
Co-authored-by: Jerry Nixon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npgsql 7.0.7 for .net6

3 participants