Update Npgsql #2207
Merged
Update Npgsql #2207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….7 is vulnerable even when updated advisory sent saying 7.0.7 is patched.
seantleonard
requested review from
Aniruddh25,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
neeraj-sharma2592,
ravishetye,
rohkhann,
severussundar,
sourabh1007 and
tarazou9
as code owners
|
/azp run |
aaronburtle
reviewed
May 10, 2024
aaronburtle
approved these changes
May 10, 2024
1 task
seantleonard
added a commit
that referenced
this pull request
May 14, 2024
## Why make this change? - Closes #2206 - As noted in #2207, now that false positive vulnerability alert no longer shows due to correct patched versions being recognized by dotnet restore. - Merging Directory to 1.1 branch. ## What is this change? - For .net6 updates npgsql to 7.0.7. - Removes "ignore" tag on serialization/deserialization test that broke because of the npgsql version used. ## How was this tested? - [x] Unit Tests - `dotnet format` step passes without dotnet restore vulnerability alert. - unit test `TestDictionaryDatabaseObjectSerializationDeserialization` unignored
ayush3797
pushed a commit
that referenced
this pull request
May 14, 2024
## Why make this change? - Closes #2206 - As noted in #2207, now that false positive vulnerability alert no longer shows due to correct patched versions being recognized by dotnet restore. - Merging Directory to 1.1 branch. ## What is this change? - For .net6 updates npgsql to 7.0.7. - Removes "ignore" tag on serialization/deserialization test that broke because of the npgsql version used. ## How was this tested? - [x] Unit Tests - `dotnet format` step passes without dotnet restore vulnerability alert. - unit test `TestDictionaryDatabaseObjectSerializationDeserialization` unignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
dotnet restore(viadotnet formatimplicitly) raises NU1903 warning as an error because older versions of npgsql are tagged as vulnerable due to a high severity vulnerability.What is this change?
-v dfor detailed verbose logging in dotnet restore step so actual error messages are shown instead of generic failure.TestDictionaryDatabaseObjectSerializationDeserialization()for .net6 until npgsql 7.0.7 for .net6 #2206 is addressed because npgsql 8.0.3 depends on system.text.json from .net8 which breaks behavior in the test.How was this tested?