Add application name for PGSQL connections #2208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogivk
requested review from
Aniruddh25,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
neeraj-sharma2592,
ravishetye,
rohkhann,
seantleonard,
severussundar,
sourabh1007 and
tarazou9
as code owners
seantleonard
approved these changes
May 10, 2024
… dev/yogkul/add_app_name_to_pgsql
… dev/yogkul/add_app_name_to_pgsql
Aniruddh25
reviewed
May 10, 2024
Aniruddh25
approved these changes
May 10, 2024
|
/azp run |
|
/azp run |
|
/azp run |
|
/azp run |
…ForBadConnectionStringHelperAsync() test function. Also cleaned up exception/console message validation to only check for connection string error: which is the sole purpose of the test.
|
/azp run |
ayush3797
pushed a commit
that referenced
this pull request
May 14, 2024
## Why make this change? Closes #1635 ## What is this change? Checking if Application Name is already present in the PgSql connection string. I f yes, we append DAB APP NAME with ',' as separator else, we add an Application Name property to connection string. ## How was this tested? - [ ] Unit Tests ## Sample Request(s) If Application Name is specified by the developer, then DAB will append to it, else will add Application Name property --------- Co-authored-by: Aniruddh Munde <[email protected]>
ayush3797
added a commit
that referenced
this pull request
May 14, 2024
## Why make this change? Ports bug-fixes to release/1.1: 1.) #2214 2.) #2215 3.) #2208 4.) #2216 --------- Co-authored-by: Yogi K <[email protected]> Co-authored-by: Aniruddh Munde <[email protected]> Co-authored-by: Sean Leonard <[email protected]> Co-authored-by: Jerry Nixon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #1635
What is this change?
Checking if Application Name is already present in the PgSql connection string. I f yes, we append DAB APP NAME with ',' as separator else, we add an Application Name property to connection string.
How was this tested?
Sample Request(s)
If Application Name is specified by the developer, then DAB will append to it, else will add Application Name property