DurableFunctions Delete Task Hub - Added PartitionCount lookup from host.json #3014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure#1715) * Function keys in Kubernetes
Keda version 1.2.0
* Add flag to skip AzureWebJobsStorage check. * Fix formatting, unit-test with blob/timer trigger Co-authored-by: Ahmed ElSayed <[email protected]>
Fixing issue Azure#1732 Updating the else if block to skip attempting to set the environmental variable when both the var and it's value are blank or null. Co-authored-by: Ahmed ElSayed <[email protected]>
* Add x64 notice installing tools for debugging For debugging under vscode, x64 installer is required * Update README.md to use '/x64' flag only Co-authored-by: Ankit Kumar <[email protected]>
Add info to make gozip executable
This reverts commit d2f17f1.
* Makes dedicated plan stream log * Prioritize py launcher for Python version detection * Prioritize python3 over python * Lossen runtime image check * Handle exception when deployment id missing case
* Add SBOM Generation to V3 (Azure#2879) * Add SBOM manifest to generated artifacts (Azure#2869) * Initial changes to add SBOM manifest to generated artifacts * Added .nuspec file for packing with manifests * Add SBOM generation for release builds * Add reference to .nuspec file * Made generateMsiFiles.ps1 script cleaner * Remove AddSBOM variable * Addressing some comments * Uncommented key steps in the pipeline and adjusted branch name comparison * Addressing further comments * Removed from the pipeline * Removed Write-Log from pipelineUtilities.psm1 * Altered installation location of dotnet * Add variable that can override SBOM generation in non-SBOM scenarios * Ensure parsing boolean environmental variables is done properly * Add [ref] for parsing boolean environmental variables * Moved condition for generating .msi files to azure-pipelines.yml * Ensure parsing of boolean environmental variable is done correctly * Added debugging statement * Removed debugging statement and fixed build command logic * Fixed condition determining build command * Ensure conditions for a full release simulation match * Correct artifacts path location * Altered the pool and vmImage * Slight modifications for V3 * Change version name in .nuspec file to be V3 instead of V4 * Update target framework in Settings.cs * Changed the target framework to netcoreapp 2.2 * Altered spacing on azure-pipelines.yml * More altered spacing * Removed IntegrationBuildNumber
removing the choco v4 install instructions as the choco v4 package is currently not available. Please see Azure#2868
* Removed appveyor references from the build pipeline
* Replaced Invoke-Expression to &{} and corrected an exception's message
* Remove quotes from commands
* Removed quotations from build command
* Altered so it would run
* Moved SimulateReleaseBuild logic to azure-pipelines.yml * Fixed small typo * Corrected another small typo
Other console messages are in the form of "Press any key to <do something>"; I added the word "key" the console output. Co-authored-by: Michael Peng <[email protected]>
* Added winget instructions to install Core Tools V3 and V4 * Add extra # to subheadings * Correct small pre-existing typo
|
@michaelpeng36 - can you please give this a look? |
|
I've been able to repro the issue that this PR aims to fix. So I can confirm the presence of the bug. That said, I'll need help to validate that the PR fixes core tools. Please see this comment to reproduce the error. |
|
Thanks for the contribution and for surfacing this issue @gorillapower. Would you be able to make your target branch |
gorillapower
requested review from
AnatoliB,
Francisco-Gamino,
alrod,
amamounelsayed,
michaelpeng36 and
vrdmr
as code owners
Sure thing. Is it correct now? |
|
Thanks for the prompt action @gorillapower. Actually, it looks like this is pulling in a couple other changes that we would like to keep separate. Would you be able to do the following?
|
|
@michaelpeng36 thanks for info! I have created new pull request here #3020 |
|
@TroyWitthoeft, Core Tools V4 is available on Chocolatey under the name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
40 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
When deleting a Task hub via the CLI, the default hardcoded partition count is used (currently 4). This means that only the default number of queues are deleted, resulting in orphaned queues in the storage account.
This pull request uses the partition count specified in the host.json if it is present.
Pull request checklist