Check if bundle config exists, hostJson exists #1882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragnagopa
requested changes
Mar 6, 2020
pragnagopa
reviewed
Mar 7, 2020
| private void ValidateHostJsonConfiguration() | ||
| { | ||
| bool IsPreCompiledApp = IsPreCompiledFunctionApp(); | ||
| var hostJsonPath = Path.Combine(Environment.CurrentDirectory, Constants.HostJsonFileName); |
There was a problem hiding this comment.
hostJsonPath is being calculated at multiple places. Move this to constant?
There was a problem hiding this comment.
I updated the logic to calculate the hostJsonPath only once. I cannot make it a constant because the value of the Environment.CurrentDirectory changes based on the context. If i make hostJson path constant the Environment.CurrentDirectory it would may end up using incorrect path.
|
|
||
| if (IsPreCompiledApp && BundleConfigurationExists(hostJsonPath)) | ||
| { | ||
| throw new CliException($"Extension bundle configuration should not be present for the function app with pre-compiled functions. Please remove extension bundle configuration from host.json: {Path.Combine(Environment.CurrentDirectory, "host.json")}"); |
There was a problem hiding this comment.
move hostJson path to constant and reuse
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pragnagopa
approved these changes
Mar 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1828