disabling sampling of requests in default host.json

[soninaren]

closes Azure/azure-functions-templates#906

[soninaren]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ahmelsayed]

any reason for this approach as opposed to just have it in the default host.json?

[soninaren]

I followed the sample of setting bundles as default in host.json. I think the only advantage we get by following this approach, is that we can introduce a flag to skip this logic in the init command no-loggingConfig. While that made sense for bundles, I don't think it does for Application Insight configuration. I will revert this change to simple add this configuration to default host.json

[ahmelsayed]

sounds good

[brettsam]

While you are doing this -- @jeffhollan (or @paulbatum... I can't remember who brought it up), weren't we discussing also adding this to the default?

"samplingSettings": {
    "isEnabled": true 
}

So it'd be much more "in your face" that sampling is enabled by default?

[soninaren]

While you are doing this -- @jeffhollan (or @paulbatum... I can't remember who brought it up), weren't we discussing also adding this to the default?

"samplingSettings": {
    "isEnabled": true 
}

So it'd be much more "in your face" that sampling is enabled by default?

Jeff added that to the issue after the PR was out. Will add that to the config as well

[soninaren]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[soninaren]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kashimiz]