content test: Aim taps on links more precisely at the text #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By saying `tester.tapAt(find.text('hello'))`, we had been aiming
at the center of the Text widgets, and expecting that to hit the
recognizer we've put on the span, even though the widget is much
wider than the span and the latter doesn't reach the former's center.
Effectively we were relying on the presence of issue zulip#214.
But with an upstream change yesterday:
flutter/flutter#140621
such a tap no longer hits the span. That broke these tests.
To fix them, aim the taps near the start of the widget instead.
Fixes: zulip#475
And update Flutter's supporting libraries to match. In particular this pulls in the following upstream change: flutter/flutter#140621 which fixes zulip#214. Fixes: zulip#214
|
Great, thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By saying
tester.tapAt(find.text('hello')), we had been aiming at the center of the Text widgets, and expecting that to hit the recognizer we've put on the span, even though the widget is much wider than the span and the latter doesn't reach the former's center. Effectively we were relying on the presence of issue #214.But with an upstream change yesterday:
TextSpanhit testing precise." (#140468) flutter/flutter#140621such a tap no longer hits the span. That broke these tests.
To fix them, aim the taps near the start of the widget instead.
Also bump the Flutter version to require that upstream change, fixing #214.
Fixes: #475
Fixes: #214