GestureRecognizer on TextSpan takes up all remaining spaces of a line instead just over the TextSpan #43400
Labels
a: quality
A truly polished experience
a: typography
Text rendering, possibly libtxt
engine
flutter/engine repository. See also e: labels.
found in release: 3.3
Found to occur in 3.3
found in release: 3.6
Found to occur in 3.6
framework
flutter/packages/flutter repository. See also f: labels.
has reproducible steps
The issue has been confirmed reproducible and is ready to work on
P2
Important issues not at the top of the work list
r: fixed
Issue is closed as already fixed in a newer version
team-engine
Owned by Engine team
triaged-engine
Triaged by Engine team
Comments
iapicca
added
a: quality
HansMuller
removed
the
c: performance
|
This happens because
This makes sense for positioning the caret in an editable text widget, but will be imprecise for hit testing the last span in non-editable text. |
VladyslavBondarenko
added
the
framework
|
I was able to reproduce this on latest sample codeflutter doctor -v |
pedromassangocode
added
found in release: 1.22
Did you find any solution? @ianloic @anaisbetts @sgraham @gmoothart @sethladd |
|
Appending a spacing TextSpan can fix this issue: TextSpan(
text: 'your text',
),
TextSpan(
// just append an spacing text
text: ' ',
), |
|
Still reproduces on the latest versions of flutter. recordingScreen.Recording.2022-12-01.at.11.14.56.movupdated sampleimport 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
void main() {
runApp(const MaterialApp(
title: 'Navigation Basics',
home: Body(),
));
}
class Body extends StatelessWidget {
const Body({super.key});
@override
Widget build(BuildContext context) {
return Container(
color: Colors.black,
margin: const EdgeInsets.all(100),
child: RichText(
softWrap: true,
text: TextSpan(
children: <InlineSpan>[
const TextSpan(
text: "very_long_starting_text",
style: TextStyle(
color: Colors.red,
)
),
const TextSpan(
text: " ",
style: TextStyle(
color: Colors.green,
decoration: TextDecoration.lineThrough,
decorationThickness: 2,
)
),
TextSpan(
text: "trailing_text",
style: const TextStyle(
color: Colors.yellow,
),
recognizer: TapGestureRecognizer()
..onTap = () {
//distinguish between real external link & jiki link
print("clicked!");
},
)
],
)
),
);
}
}flutter doctor -v |
danagbemava-nc
added
found in release: 3.3
flutter-triage-bot
bot
added
multiteam-retriage-candidate
team-engine
8 tasks
auto-submit bot
pushed a commit
that referenced
this issue
Dec 20, 2023
Fixes #131435, #104594, #43400 Needs flutter/engine#48774 (to fix the web test failure). Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text. The new TextPaintes method tells you the layout bounds (`width = letterspacing / 2 + x_advance + letterspacing / 2`, `height = font ascent + font descent`) of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of it's character's layout bounds. Potential issues: 1. In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference. This is a breaking change. It also introduces a new finder and a new method `WidgetTester.tapOnText`: `await tester.tapOnText('string to match')` for ease of migration.
8 tasks
auto-submit bot
added a commit
that referenced
this issue
Dec 20, 2023
Reverts #139717 Initiated by: LongCatIsLooong This change reverts the following previous change: Original Description: Fixes #131435, #104594, #43400 Needs flutter/engine#48774 (to fix the web test failure). Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text. The new TextPaintes method tells you the layout bounds (`width = letterspacing / 2 + x_advance + letterspacing / 2`, `height = font ascent + font descent`) of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of it's character's layout bounds. Potential issues: 1. In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference. This is a breaking change. It also introduces a new finder and a new method `WidgetTester.tapOnText`: `await tester.tapOnText('string to match')` for ease of migration.
8 tasks
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this issue
Dec 28, 2023
Fixes flutter#131435, flutter#104594, flutter#43400 Needs flutter/engine#48774 (to fix the web test failure). Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text. The new TextPaintes method tells you the layout bounds (`width = letterspacing / 2 + x_advance + letterspacing / 2`, `height = font ascent + font descent`) of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of it's character's layout bounds. Potential issues: 1. In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference. This is a breaking change. It also introduces a new finder and a new method `WidgetTester.tapOnText`: `await tester.tapOnText('string to match')` for ease of migration.
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this issue
Dec 28, 2023
Reverts flutter#139717 Initiated by: LongCatIsLooong This change reverts the following previous change: Original Description: Fixes flutter#131435, flutter#104594, flutter#43400 Needs flutter/engine#48774 (to fix the web test failure). Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text. The new TextPaintes method tells you the layout bounds (`width = letterspacing / 2 + x_advance + letterspacing / 2`, `height = font ascent + font descent`) of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of it's character's layout bounds. Potential issues: 1. In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference. This is a breaking change. It also introduces a new finder and a new method `WidgetTester.tapOnText`: `await tester.tapOnText('string to match')` for ease of migration.
auto-submit bot
pushed a commit
that referenced
this issue
Jan 2, 2024
Fixes #131435, #104594, #43400 Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text. The new TextPaintes method tells you the layout bounds `(width = letterspacing / 2 + x_advance + letterspacing / 2, height = font ascent + font descent)` of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of its character's layout bounds. Potential issues: In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference. This is a breaking change.
|
Fixed by #140621. |
This was referenced Jan 4, 2024
danagbemava-nc
added
the
r: fixed
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
produces the following effect
when click on the area after the yelllow "trailing_text"
"clicked!" is printed
flutter doctor -v
The text was updated successfully, but these errors were encountered: