msglist: Share recipient headers across messages #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was initially written when we didn't depend on the store in the actual build phase. But now we do, so we have it around at this point and might as well use it.
This makes room to add a bit more complexity to some of the cases.
… bottom We're already relying on this assumption in the code to add a new message, in _processMessage. We'll add the needed complications there when they become needed.
Instead of showing recipient headers as part of each MessageListMessageItem, they're now their own message-list items. At this stage, we still show one for each message.
chrisbobbe
reviewed
Sep 8, 2023
test/model/message_list_test.dart
Outdated
| // are present just where [canShareRecipientHeader] requires them. | ||
| // In [checkInvariants] we check the current state against that invariant, | ||
| // so here we just need to exercise that code through all the relevant cases. | ||
| // Each [checkNotifiedOnce] call ensures there's been a [checkInvariants] call. |
There was a problem hiding this comment.
How does each checkNotifiedOnce call ensure there's been a checkInvariants call? It doesn't call checkInvariants itself, right:
void checkNotified({required int count}) {
check(notifiedCount).equals(count);
notifiedCount = 0;
}
void checkNotNotified() => checkNotified(count: 0);
void checkNotifiedOnce() => checkNotified(count: 1);There was a problem hiding this comment.
Right. But the only way for notifiedCount to have been set greater than zero is in this listener:
model = MessageListView.init(store: store, narrow: narrow)
..addListener(() {
checkInvariants(model);
notifiedCount++;
});and that calls checkInvariants.
So if checkNotifiedOnce succeeds (or checkNotified with any positive argument), then there must have been a call to that listener and it must have successfully called checkInvariants.
There was a problem hiding this comment.
Oh! OK, yeah, that makes sense.
gnprice
force-pushed
the
pr-recipient-headers
branch
from
b727adb to
c5e7027
Compare
|
Thanks for the review! Expanded that comment to answer your question. |
|
Great, thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #174
Screenshot with recipients changing:
Screenshot with the date changing:
