-
Notifications
You must be signed in to change notification settings - Fork 309
Suppress repeated recipient headers #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
a-msglist
The message-list screen, except what's label:a-content
a-sticky_header
Our `sticky_header` library
Milestone
Comments
I have a draft branch for this feature (and #175). The complicated part (and this was predictable once you think through it, but I didn't realize it until I picked this up the other day) is that this requires reworking our approach to making the recipient headers sticky.
|
Closed
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Aug 31, 2023
In particular this gives us two features we'll want in the Zulip message list when we go to make recipient headers appear only where needed (zulip#174): * An item's header now gets built (and laid out and painted) only if the item is actually the one at the relevant edge of the viewport such that the stickiness comes into play. This lets us attach a sticky header to every message, even when it shares a recipient header with the message that comes before it. * An item can now (optionally) allow the header's stickiness at the edge of the viewport to take precedence over the header's confinement within the item's own bounds. We'll use this to let the header stay pinned when scrolling between items that share a recipient header.
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Sep 7, 2023
chrisbobbe
pushed a commit
that referenced
this issue
Sep 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a-msglist
The message-list screen, except what's label:a-content
a-sticky_header
Our `sticky_header` library
In Zulip web and zulip-mobile, when consecutive messages have the same recipient information, we don't repeat the recipient header. This makes a big difference for the flow of reading a conversation, and we should do the same.
If we do a version of this before we have date separators #173, then we should repeat the recipient header when the date changes, in order to show the new date (with #172). If we already have #173, then we should suppress recipient headers across dates too.
The text was updated successfully, but these errors were encountered: