-
-
Notifications
You must be signed in to change notification settings - Fork 95
Translations update from Hosted Weblate #1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations update from Hosted Weblate #1220
Conversation
Currently translated at 100.0% (137 of 137 strings) Translation: KeyPass/KeyPass Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/zh_Hans/
WalkthroughThis update refines Chinese (Simplified, China) string resources in the application's localization files. It revises translations for clarity and accuracy, correcting ambiguous or partially untranslated phrases and improving the quality of UI labels and descriptions. No code or logic changes are included. Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (4)
app/src/main/res/values-zh-rCN/strings.xml (4)
14-14: Prefer “从备份中恢复密码” for natural phrasingAdding “中” makes the sentence flow more naturally in Chinese.
- <string name="restore_credentials_desc">从备份恢复密码</string> + <string name="restore_credentials_desc">从备份中恢复密码</string>
92-92: Use “备份” instead of “导出” for consistency with other stringsMost similar entries (“KeyPass 备份”, “自动备份”等) use “备份”. Keeping the term aligned avoids confusing the user.
- <string name="google_backup">Chrome/Google 密码导出</string> + <string name="google_backup">Chrome/Google 密码备份</string>
132-132: Term inconsistency: “关键短语” vs “密钥短语”Elsewhere (e.g., lines 117–122) the project uses “密钥短语”. Unify the wording to avoid confusing users.
- <string name="backup_screen_desc">安全地备份凭据防止数据丢失。备份文件使用关键短语加密。</string> + <string name="backup_screen_desc">安全地备份凭据防止数据丢失。备份文件使用密钥短语加密。</string>
138-138: Flow improvement for “contact_via_email”The current wording is slightly awkward. Consider re-ordering for smoother reading.
- <string name="contact_via_email">发送电子邮件,提出支持请求、建议、反馈等</string> + <string name="contact_via_email">通过电子邮件发送支持请求、建议、反馈等</string>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/src/main/res/values-zh-rCN/strings.xml(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Tests and Build Production Debug Build
| <string name="keepass_backup">KeePass CSV 导出</string> | ||
| <string name="keepass_backup_desc">从 KeePass CSV 文件导入密码</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Label/description mismatch — export vs import
The title says “导出” (export) while the description says “导入” (import). One of them is wrong; pick either export or import and update both strings to match.
- <string name="keepass_backup">KeePass CSV 导出</string>
- <string name="keepass_backup_desc">从 KeePass CSV 文件导入密码</string>
+ <string name="keepass_backup">KeePass CSV 导入</string>
+ <string name="keepass_backup_desc">从 KeePass CSV 文件导入密码</string>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <string name="keepass_backup">KeePass CSV 导出</string> | |
| <string name="keepass_backup_desc">从 KeePass CSV 文件导入密码</string> | |
| <string name="keepass_backup">KeePass CSV 导入</string> | |
| <string name="keepass_backup_desc">从 KeePass CSV 文件导入密码</string> |
🤖 Prompt for AI Agents
In app/src/main/res/values-zh-rCN/strings.xml around lines 95 to 96, the label
and description for keepass_backup are inconsistent, with the label indicating
export ("导出") and the description indicating import ("导入"). Decide whether this
feature is for exporting or importing KeePass CSV files, then update both
strings to consistently reflect that action by changing the text in both the
label and description accordingly.
Translations update from Hosted Weblate for KeyPass/KeyPass.
It also includes following components:
Current translation status:
Summary by CodeRabbit