Implements: Highlight and scroll widget into view in preview window #13
Conversation
Adds effects to editing widgets, border effect on control hover, and scrolls to widget on input click.
|
Looking forward to trying this out! /five |
|
@rfvcorreia could you update your branch with the latest from our repo? I just merged in an earlier pull request from @johnregan3 and it seems to conflict with your changes. |
|
Sure, I'll work on it tonight and add the expand feature also. |
Conflicts: widget-customizer.css widget-customizer.js
…omizer Conflicts: widget-customizer-preview.js widget-customizer.js
… control on widget preview click
|
Conflict with @johnregan3 PR fixed. |
There was a problem hiding this comment.
@rfvcorreia there's some intermixed tab vs spaces indentation here
|
@rfvcorreia I've created a new branch I'll keep pulling any additional commits from your branch into this branch. Please pull my commits as well. |
There was a problem hiding this comment.
@rfvcorreia this was not working for me because the selector evaluated as soon as the script loaded and not upon jQuery.ready, so for me the widgets weren't even in the page yet. I've moved the logic to a function that gets called once the DOM has been loaded, and I attached the event handlers with delegated events, so that if new widgets appear later (#3) they'll also be recognized.
Fixed in 2ead257.
|
@rfvcorreia actually you want to pull from |
There was a problem hiding this comment.
@rfvcorreia this has a great effect, but I'm afraid that scrolling the body, html may not be compatible in all situations. For example, what if the widget appears inside of a sidebar that itself is a scrollable area? Scrolling the body/html wouldn't help in that case, and they'd actually need to scroll the sidebar container element. So I've switched to using el.scrollIntoView() for now: c53232b
|
Commits from pull request merged. |
894d120 Merge pull request #18 from x-team/issue-16 de1db88 Remove wordpress- from url 5581e97 Get latest trunk file from github 9d1d025 Add base phpcs ruleset for plugins 5de1b8e Update .jshintrc to match new in core ab7b9cd Update .tavis.yml to check against master and latest. This closes #16 and #15 9aa3e33 Merge pull request #17 from jonathanbardo/master 63a11a4 Correct small typo 8e3bab1 Merge pull request #15 from jonathanbardo/master ed0b379 Update WP version to latest stable release 6956ba1 Merge pull request #13 from jonathanbardo/master a864385 Update WP_VERSION to 3.7 4cd538f Merge branch 'master' of github.com:x-team/wp-plugin-dev-lib 258cdf9 Fix reference from jshint to phpcs c9f45eb Add formatting 7d26511 Add git-subtree instructions 9c1e6ea Update svn-push to work with svn repo out of git repo git-subtree-dir: bin git-subtree-split: 894d120dd0047c75076df7d37a8d9b81bb15aa41
2 participants
I've used master for the changes, on Widget click in preview a border is added in control, instead of expanding it as feature is not in master.
Fixes #5