-
Notifications
You must be signed in to change notification settings - Fork 292
CP-45921: Use dnf as package manager for XS9 #5534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test done:
|
0965298
to
f08e6e8
Compare
psafont
reviewed
Mar 27, 2024
minglumlu
reviewed
Mar 28, 2024
minglumlu
reviewed
Mar 28, 2024
f08e6e8
to
78c87b7
Compare
lindig
reviewed
Mar 28, 2024
5652e89
to
573712d
Compare
Given XS9 has updated to dnf and no yum is available, xapi will choose package manager basing on following - If dnf exists, use dnf - otherwise, fallback to yum xapi just presume dnf or yum is available in the system. Because xapi decides to use dnf or yum according to the running environment, this commit is compatible with yum/xs8 and dnf/xs9 Signed-off-by: Lin Liu <[email protected]>
Signed-off-by: Lin Liu <[email protected]>
573712d
to
3267e99
Compare
XenRT after code refine:
|
Signed-off-by: Lin Liu <[email protected]>
lindig
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally fine but I would like to see the result values better explained by using the type system.
psafont
reviewed
Apr 2, 2024
psafont
reviewed
Apr 2, 2024
psafont
reviewed
Apr 2, 2024
psafont
reviewed
Apr 2, 2024
psafont
reviewed
Apr 2, 2024
psafont
reviewed
Apr 2, 2024
- Move test code to its own suite - Replace active with manager, which is static - Add cmd_line record type to abstract cmd line type - Refine doc comment and license Signed-off-by: Lin Liu <[email protected]>
025116d
to
1ad5244
Compare
psafont
approved these changes
Apr 3, 2024
Final XenRT happy:
|
pytype_reporter extracted 50 problem reports from pytype output. You can check the results of the job here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given XS9 has updated to dnf and no yum is available, xapi will choose package manager basing on following
Because xapi decides to use dnf or yum according to the running environment, this commit is compatible with yum/xs8 and dnf/xs9