Skip to content

Conversation

liulinC
Copy link
Collaborator

@liulinC liulinC commented Mar 27, 2024

Given XS9 has updated to dnf and no yum is available, xapi will choose package manager basing on following

  • If dnf exists, use dnf
  • otherwise, fallback to yum xapi just presume dnf or yum is available in the system.

Because xapi decides to use dnf or yum according to the running environment, this commit is compatible with yum/xs8 and dnf/xs9

@liulinC
Copy link
Collaborator Author

liulinC commented Mar 27, 2024

Test done:

  • Manual test for XS8 and XS9: xe pool-sync-updates
  • XS8 repoupdatesanity.seq 3965921
  • XS9: repoupdatesanity.seq 3965846

@liulinC liulinC force-pushed the private/linl/dnf branch 3 times, most recently from 0965298 to f08e6e8 Compare March 27, 2024 10:28
@liulinC liulinC force-pushed the private/linl/dnf branch 2 times, most recently from 5652e89 to 573712d Compare March 29, 2024 06:03
liulinC added 2 commits April 1, 2024 03:42
 Given XS9 has updated to dnf and no yum is available,
 xapi will choose package manager basing on following
 - If dnf exists, use dnf
 - otherwise, fallback to yum
 xapi just presume dnf or yum is available in the system.

 Because xapi decides to use dnf or yum according to the running
 environment, this commit is compatible with yum/xs8 and dnf/xs9

Signed-off-by: Lin Liu <[email protected]>
Signed-off-by: Lin Liu <[email protected]>
@liulinC liulinC force-pushed the private/linl/dnf branch from 573712d to 3267e99 Compare April 1, 2024 04:19
@liulinC liulinC requested review from lindig, minglumlu and psafont April 2, 2024 00:40
@liulinC
Copy link
Collaborator Author

liulinC commented Apr 2, 2024

XenRT after code refine:

  • XS8: 3970219
  • XS9: 3970218

Copy link
Contributor

@lindig lindig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine but I would like to see the result values better explained by using the type system.

- Move test code to its own suite
- Replace active with manager, which is static
- Add cmd_line record type to abstract cmd line type
- Refine doc comment and license

Signed-off-by: Lin Liu <[email protected]>
@liulinC liulinC force-pushed the private/linl/dnf branch from 025116d to 1ad5244 Compare April 3, 2024 06:14
@liulinC liulinC requested a review from psafont April 3, 2024 06:26
@liulinC
Copy link
Collaborator Author

liulinC commented Apr 3, 2024

Final XenRT happy:

  • XS9: 3970873
  • XS8: 3970874

@liulinC liulinC merged commit e1f14a7 into xapi-project:feature/xs9 Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

pytype_reporter extracted 50 problem reports from pytype output

.

You can check the results of the job here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants