This repository was archived by the owner on Sep 15, 2025. It is now read-only.
AINFRA-283 - Set queue: mac explicitly in pipeline
#838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow adopting an improved default pipeline upload step on the CI infrastructure side of the setup. It also makes it clear what queue is in use just by looking at the pipeline file. Notice it does not introduce the standard `shared-pipeline-vars` file because to use that we first need the default pipeline upload step in the IaC configuration.
AliSoftware
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
Tests are failing but that's unrelated with the changes in this PR, they fail on #816, too. Given how WordPressKit has changed to ship as an XCFramework and that currently WordPress-Jetpack-Reader is the only consumer, I decided not to investigate
👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow adopting an improved default pipeline upload step on the CI infrastructure side of the setup. It also makes it clear what queue is in use just by looking at the pipeline file.
Notice it does not introduce the standard
shared-pipeline-varsfile because to use that we first need the default pipeline upload step in the IaC configuration.See https://linear.app/a8c/issue/AINFRA-283
Note
Tests are failing but that's unrelated with the changes in this PR, they fail on #816, too. Given how WordPressKit has changed to ship as an XCFramework and that currently WordPress-Jetpack-Reader is the only consumer, I decided not to investigate. I'm happy to if required, but my current understanding is that this repo is on life support and will see minimal changes, meaning investing in does not give the best RoI.
Note
I targeted #816 instead of
trunkbecause WordPress-Jetpack-Reader is the only consumer of this library. As such, I propose merging #816 and making it the main branch, adding a note on the state of the project. See also pbArwn-7sp-p2