Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Conversation

kean
Copy link
Contributor

@kean kean commented Jul 12, 2024

Description

This branch contains an archived version of WordPressKit designed to be used exclusively by WordPress-iOS. Consider it a release branch.

This version of WordPressKit is distributed using SwiftPM as a binary target. It has no dependencies to WordPressShared and UIDeviceIdentifier, and it imports wpxmlrpc and NSObject_SafeExtensions as @_implementationOnly, so there are not exposed in the public interface.

Updating WordPressKit

On an off chance that the WordPressKit version used by WordPress-iOS needs a patch, please submit it by targeting this branch.

Deployment Instructions

The deployment currently requires a few manual steps, but we don't expect it to be needed often.

  • Run .buildkite/create-xcframeworks.sh to create binaries
  • Upload .build/xcframeworks/WordPressKit.zip to this repo
  • Update binary target in Package.swift with a new URL and checksum*
  • Push the new changes to your branch
  • (After testing is done) Merge changes in wpios-edition

checksum is echoed at the end of the create-xcframeworks.sh script

@dangermattic
Copy link
Collaborator

dangermattic commented Jul 12, 2024

2 Warnings
⚠️ Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages in Xcode.
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@kean kean changed the title WordPress-iOS Edition WordPress-iOS Edition [Do Not Merge] Jul 13, 2024
@kean
Copy link
Contributor Author

kean commented Jul 13, 2024

Versions:

@kean kean force-pushed the wpios-edition branch 2 times, most recently from ed81029 to 7ab0ebe Compare July 13, 2024 01:22
@kean kean requested a review from jkmassel July 15, 2024 13:42
kean and others added 6 commits May 12, 2025 15:49
This will allow adopting an improved default pipeline upload step on the
CI infrastructure side of the setup. It also makes it clear what queue
is in use just by looking at the pipeline file.

Notice it does not introduce the standard `shared-pipeline-vars` file
because to use that we first need the default pipeline upload step in
the IaC configuration.
@mokagio
Copy link
Contributor

mokagio commented Jun 24, 2025

In the context of linear.app/a8c/issue/AINFRA-283 and as discussed in pbArwn-7sp-p2, I'm going to merge this into #816 and then #816 into trunk.

In short: WordPress-Jetpack-Reader iOS is now the only client of WordPressKit, so it's okay to have all this on trunk.

We can let the fact the tests don't pass slide for the moment.

Thanks!

@mokagio mokagio marked this pull request as ready for review June 24, 2025 10:14
@mokagio mokagio merged commit 8be531d into trunk Jun 24, 2025
5 of 7 checks passed
@mokagio mokagio deleted the wpios-edition branch June 24, 2025 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants