-
Notifications
You must be signed in to change notification settings - Fork 734
Infra/assets internal #3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Infra/assets internal #3618
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
627ecbb
Add internal assets module with icons and images
adids1221 09884c2
Refactor icon imports to use internal assets for consistency
adids1221 517b077
Refactor asset imports to use internal structure and remove assets.ic…
adids1221 2219ccb
Add xSmall icon and update ChipsInput to use internal assets
adids1221 bf5b253
Add transparentSwatch icon and update ColorSwatch component to use it
adids1221 9c59698
Add dropdown to icons and update useFieldType to utilize internal assets
adids1221 76d7e03
Add hintTip icons and update Hint component to use internal assets
adids1221 c25d1e5
Add checkMarkSmall and exclamationSmall icons, update WizardStates to…
adids1221 1224520
Add gradient overlay images and update Overlay component to use inter…
adids1221 5bac3cf
Add gradientOverlay image and update ScrollBar component to use it
adids1221 893c73e
move hint, swatch assets to internal.images
adids1221 656b0ac
Rename icons.dropdown to icons.chevronDown
adids1221 d9168a8
Add icons.demo and update references in components screens
adids1221 f5099c3
rename checkSmall icon file and update icons - index.js reference
adids1221 64e5930
Merge branch 'master' into infra/Assets_internal
adids1221 94b12f8
Update ColorSwatch to use internal.images for transparentSwatch
adids1221 c7e17a0
Merge branch 'master' into infra/Assets_internal
adids1221 9aee276
Stepper local assets remove, move to Assets
adids1221 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,10 @@ | ||
import {Assets} from './Assets'; | ||
|
||
export default new Assets().loadAssetsGroup('', { | ||
get icons() { | ||
return require('./icons').icons; | ||
}, | ||
get emojis() { | ||
return require('./emojis').emojis; | ||
}, | ||
get images() { | ||
return require('./images').images; | ||
get internal() { | ||
return require('./internal').internal; | ||
} | ||
}); |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
export const icons = { | ||
get check() { | ||
return require('./check.png'); | ||
}, | ||
get checkMarkSmall() { | ||
return require('./checkMarkSmall.png'); | ||
}, | ||
get checkSmall() { | ||
return require('./checkSmall.png'); | ||
}, | ||
get chevronDown() { | ||
return require('./chevronDown.png'); | ||
}, | ||
get exclamationSmall() { | ||
return require('./exclamationSmall.png'); | ||
}, | ||
get minusOutline() { | ||
return require('./minusOutline.png'); | ||
}, | ||
get minusOutlineSmall() { | ||
return require('./minusOutlineSmall.png'); | ||
}, | ||
get minusSmall() { | ||
return require('./minusSmall.png'); | ||
}, | ||
get plusOutline() { | ||
return require('./plusOutline.png'); | ||
}, | ||
get plusOutlineSmall() { | ||
return require('./plusOutlineSmall.png'); | ||
}, | ||
get plusSmall() { | ||
return require('./plusSmall.png'); | ||
}, | ||
get search() { | ||
return require('./search.png'); | ||
}, | ||
get x() { | ||
return require('./x.png'); | ||
}, | ||
get xFlat() { | ||
return require('./xFlat.png'); | ||
}, | ||
get xMedium() { | ||
return require('./xMedium.png'); | ||
}, | ||
get xSmall() { | ||
return require('./xSmall.png'); | ||
} | ||
}; |
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
export const images = { | ||
get gradient() { | ||
return require('./gradient.png'); | ||
}, | ||
get gradientOverlay() { | ||
return require('./gradientOverlay.png'); | ||
}, | ||
get gradientOverlayHigh() { | ||
return require('./gradientOverlayHigh.png'); | ||
}, | ||
get gradientOverlayLow() { | ||
return require('./gradientOverlayLow.png'); | ||
}, | ||
get gradientOverlayMedium() { | ||
return require('./gradientOverlayMedium.png'); | ||
}, | ||
get hintTipMiddle() { | ||
return require('./hintTipMiddle.png'); | ||
}, | ||
get hintTipSide() { | ||
return require('./hintTipSide.png'); | ||
}, | ||
get transparentSwatch() { | ||
return require('./transparentSwatch.png'); | ||
} | ||
}; |
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
export const internal = { | ||
get icons() { | ||
return require('./icons').icons; | ||
}, | ||
get images() { | ||
return require('./images').images; | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move the snap tests to the component's dir, they shouldn't be in the demo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then you'll be referencing the demo from the src code
Also, focus on the assets change, if you decide to do other changes, do it in another PR please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we do it already in other snaps and in private as well. I think we better keep tests in src instead of the demo