-
Notifications
You must be signed in to change notification settings - Fork 734
Infra/assets internal #3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra/assets internal #3618
Conversation
… use internal assets
@adids1221 If we're using Assets.internal.icons in our demo screens our users will assume they can use them too. Can we find a solution to mask this usage? (also, we have assets dir in the demo...) |
@@ -3933,7 +3933,7 @@ exports[`TextField Screen renders screen 1`] = ` | |||
accessible={false} | |||
source={ | |||
{ | |||
"testUri": "../../../src/assets/icons/xFlat.png", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move the snap tests to the component's dir, they shouldn't be in the demo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then you'll be referencing the demo from the src code
Also, focus on the assets change, if you decide to do other changes, do it in another PR please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we do it already in other snaps and in private as well. I think we better keep tests in src instead of the demo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adids1221
I see you use Assets.internal.icons in both src code and demo example screens
IMO, we should it only in the our src code.
For the demo screens (mobile or web) we should demonstrate how the user can load their own assets and use it, we are already doing it, you can find the demo/src/configurations.js
file where we configure the demo assets.
Let's use these assets for our example screens instead
Fixed the demo screens Assets usage, changed some file names. |
Description
Assets new
internal
path, moved local components assets to be underAssets.internal.icons
.Component which are part of this PR:
ChipsInput, ColorSwatch, Picker - FieldType, Hint, Wizard, Overaly, ScrollBar, Stepper
This is part of the web effort to support assets.
TODO: add StackAggregator
.Old PR #3602 closed
Changelog
Assets new
internal
path, moved local components assets to be underAssets.internal.icons
.Additional info
MADS-4531