h264 encoder patch #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
cloudwebrtc
pushed a commit
that referenced
this pull request
Oct 27, 2021
…pdating layers. When implicit start/stop happens via activation/deactivation of layers occurs, don't change the state of the 'alive' flag since further activations following full de-activation need to be allowed to happen when Stop() has not been called. (cherry picked from commit 264cf54) Bug: chromium:1234779 Change-Id: Ic3cae387990122eaa2f48de096ff9dafa7c34414 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228242 Reviewed-by: Magnus Flodman <[email protected]> Commit-Queue: Tommi <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#34698} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228900 Reviewed-by: Mirko Bonadei <[email protected]> Cr-Commit-Position: refs/branch-heads/4577@{#6} Cr-Branched-From: 5196931-refs/heads/master@{#34463}
davidliu
pushed a commit
to davidliu/webrtc
that referenced
this pull request
Feb 8, 2022
davidliu
pushed a commit
to davidliu/webrtc
that referenced
this pull request
Feb 9, 2022
davidliu
pushed a commit
that referenced
this pull request
Feb 10, 2022
davidliu
pushed a commit
that referenced
this pull request
Jul 17, 2022
…tically assigned payload types to allow for downstream users to upgrade. BUG=chromium:1338902 (cherry picked from commit 62c20f3) No-Try: True Change-Id: If6b56ab63f7859c13e9ebc70326e1088e5dfff1a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268141 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#37475} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268142 Reviewed-by: Henrik Boström <[email protected]> Reviewed-by: Philipp Hancke <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Cr-Commit-Position: refs/branch-heads/5112@{#6} Cr-Branched-From: a976a87-refs/heads/main@{#37168}
davidliu
pushed a commit
that referenced
this pull request
Jul 17, 2022
davidliu
pushed a commit
that referenced
this pull request
Jul 21, 2022
giangndm-bluesea
pushed a commit
to giangndm-bluesea/webrtc
that referenced
this pull request
Jan 14, 2023
…rtc-sdk#6/n) Controlled by a field trial, P2PTransportChannel can now use an active ICE controller instead of a legacy ICE controller. P2PTransportChannel unit tests need non-trivial changes to exercise the refactored code path, so the testing changes are added in a follow-up CL. Bug: webrtc:14367, webrtc:14131 Change-Id: I00d4930a5692c7d6d331ea9d6c2a2199304e363c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274701 Commit-Queue: Sameer Vijaykar <[email protected]> Reviewed-by: Jonas Oreland <[email protected]> Reviewed-by: Per Kjellander <[email protected]> Cr-Commit-Position: refs/heads/main@{#38114}
cloudwebrtc
pushed a commit
that referenced
this pull request
Jan 18, 2023
cloudwebrtc
pushed a commit
that referenced
this pull request
Jun 5, 2023
JacobCopley
pushed a commit
to Auditory-Defense/webrtc
that referenced
this pull request
Oct 10, 2025
This fixes a problem affecting PeerConnectionWrapper and other classes using FakeSetLocalDescriptionObserver and FakeSetRemoteDescriptionObserver whereby callbacks would arrive on a different thread than the test thread. This has caused some flake in tests, but mostly has been masked by other synchronous blocking calls between the test thread and signaling thread. The pattern was that the fake observer object was being polled from the test thread until an operation completed on the signaling thread, leading to tsan errors such as detected here: https://chromium-swarm.appspot.com/task?id=735c37c9a2b00011&o=true&w=true Brief (and trimmed) example stacks: WARNING: ThreadSanitizer: data race (pid=259249) Write of size 1 at 0x721000023d70 by thread T1: ... webrtc-sdk#2 FakeSetLocalDescriptionObserver::OnSetLocalDescriptionComplete(...) webrtc-sdk#3 SdpOfferAnswerHandler::DoSetLocalDescription(...) ... webrtc-sdk#5 rtc_operations_chain_internal::OperationWithFunctor<...>::Run() webrtc-sdk#6 ChainOperation<(lambda at ../../pc/sdp_offer_answer.cc:1678:7)> webrtc-sdk#7 SdpOfferAnswerHandler::SetLocalDescription(...) ... Previous read of size 1 at 0x721000023d70 by main thread: ... webrtc-sdk#1 called pc/test/mock_peer_connection_observers.h:356:39 webrtc-sdk#2 operator() pc/peer_connection_wrapper.cc:183:3 webrtc-sdk#3 operator() test/wait_until.h:84:24 ... webrtc-sdk#6 WaitUntil(FunctionView<bool ()>, WaitUntilSettings) webrtc-sdk#7 WaitUntil<(lambda at ../../pc/peer_connection_wrapper.cc:183:3)> webrtc-sdk#8 PeerConnectionWrapper::SetLocalDescription(...) ... Bug: none Change-Id: Iadc4634fe78d5d1b252b1a3c05d7ae9c5b76922c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/409340 Reviewed-by: Danil Chapovalov <[email protected]> Commit-Queue: Tomas Gunnarsson <[email protected]> Cr-Commit-Position: refs/heads/main@{#45651}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies h264 encoder patch to prevent segmentation fault when downgrading simulcast.
Credit to the following patches
https://github.com/shiguredo-webrtc-build/webrtc-build/blob/master/patches/macos_simulcast.patch
https://github.com/shiguredo-webrtc-build/webrtc-build/blob/master/patches/macos_h264_encoder.patch