Skip to content

Commit 701c8ff

Browse files
fippoWebRTC LUCI CQ
authored andcommitted
[merge to M104] sdp: temporarily relax clockrate requirements for statically assigned payload types
to allow for downstream users to upgrade. BUG=chromium:1338902 (cherry picked from commit 62c20f3) No-Try: True Change-Id: If6b56ab63f7859c13e9ebc70326e1088e5dfff1a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268141 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#37475} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268142 Reviewed-by: Henrik Boström <[email protected]> Reviewed-by: Philipp Hancke <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Cr-Commit-Position: refs/branch-heads/5112@{#6} Cr-Branched-From: a976a87-refs/heads/main@{#37168}
1 parent 7e74f2b commit 701c8ff

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

pc/webrtc_sdp.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3633,9 +3633,9 @@ bool ParseRtpmapAttribute(absl::string_view line,
36333633

36343634
AudioContentDescription* audio_desc = media_desc->as_audio();
36353635
for (const cricket::AudioCodec& existing_codec : audio_desc->codecs()) {
3636+
// TODO(crbug.com/1338902) re-add check for clockrate.
36363637
if (!existing_codec.name.empty() && payload_type == existing_codec.id &&
36373638
(!absl::EqualsIgnoreCase(encoding_name, existing_codec.name) ||
3638-
clock_rate != existing_codec.clockrate ||
36393639
channels != existing_codec.channels)) {
36403640
rtc::StringBuilder description;
36413641
description

pc/webrtc_sdp_unittest.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4665,11 +4665,10 @@ TEST_F(WebRtcSdpTest, DuplicateAudioRtpmapWithConflict) {
46654665
"s=-\r\n"
46664666
"t=0 0\r\n"
46674667
"m=audio 49232 RTP/AVP 108\r\n"
4668-
// Same name but different payload type.
46694668
"a=rtpmap:108 ISAC/16000\r\n"
4670-
"a=rtpmap:108 ISAC/32000\r\n";
4669+
"a=rtpmap:108 G711/16000\r\n";
46714670

4672-
ExpectParseFailure(sdp, "a=rtpmap:108 ISAC/32000");
4671+
ExpectParseFailure(sdp, "a=rtpmap:108 G711/16000");
46734672
}
46744673

46754674
TEST_F(WebRtcSdpTest, DuplicateVideoRtpmapWithConflict) {

0 commit comments

Comments
 (0)