Skip to content

docs(guides): Make all demo context consistently #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Ivocin
Copy link
Contributor

@Ivocin Ivocin commented Mar 15, 2019

I read the guides and find that some demos aren't consistent.
This pr contains three parts:

@RedTn
Copy link

RedTn commented Apr 20, 2019

@Ivocin @EugeneHlushko What's status on this? Ran into bug with CleanWebpackPlugin on production guide and this PR resolves it. Need my help to take it over?

@EugeneHlushko
Copy link
Member

@Ivocin can you resolve conflicts? an earlier pr to let const was merged

@Ivocin
Copy link
Contributor Author

Ivocin commented Apr 23, 2019

@Ivocin can you resolve conflicts? an earlier pr to let const was merged

Close, another pr has been merged.

@Ivocin Ivocin closed this Apr 23, 2019
@EugeneHlushko
Copy link
Member

@Ivocin can you quickly open a new PR where you do changes for CleanWebpackPlugin from this pr's diff ?

@RedTn
Copy link

RedTn commented Apr 23, 2019

I can take it if he's unavailable

@EugeneHlushko
Copy link
Member

Hi and thank you @RedTn but i already have a branch with such changes, just wanted to get original contributor to respond first

@EugeneHlushko
Copy link
Member

Updated the branch and pushed the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants