Skip to content

docs(guides): change CleanWebpackPlugin arguments usage #2845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 6, 2019

Conversation

Ivocin
Copy link
Contributor

@Ivocin Ivocin commented Mar 5, 2019

CleanWebpackPlugin released v2.0.0 and the API has a breaking change: No configuration is needed for standard usage (cleans webpack's output.path).

new CleanWebpackPlugin(['dist/*']) with the new version clean-webpack-plugin installed above will cause an error:
"Error: clean-webpack-plugin only accepts an options object. See: https://github.com/johnagan/clean-webpack-plugin#options-and-defaults-optional "

CleanWebpackPlugin released  v2.0.0 and the API has a breaking change: No configuration is needed for standard usage (cleans webpack's output.path).
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was released a day ago, suggesting to add a comment like this or think in this direction

@EugeneHlushko EugeneHlushko requested a review from montogeek March 5, 2019 21:22
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, i am hesitant if we should also add a + to the comment line so its highlighted....

screen shot 2019-03-06 at 11 43 38 am

@Ivocin
Copy link
Contributor Author

Ivocin commented Mar 6, 2019

It looks good to me, i am hesitant if we should also add a + to the comment line so its highlighted....

screen shot 2019-03-06 at 11 43 38 am

add a + is a good idea, because the previous demo code above doesn't have this line.

@montogeek montogeek merged commit ee984f7 into webpack:master Mar 6, 2019
@montogeek
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants