Skip to content

docs(guides): Make all demo context consistently #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/content/guides/asset-management.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ __src/index.js__
+ import './style.css';

function component() {
var element = document.createElement('div');
let element = document.createElement('div');

// Lodash, now imported by this script
element.innerHTML = _.join(['Hello', 'webpack'], ' ');
Expand Down Expand Up @@ -217,14 +217,14 @@ __src/index.js__
+ import Icon from './icon.png';

function component() {
var element = document.createElement('div');
let element = document.createElement('div');

// Lodash, now imported by this script
element.innerHTML = _.join(['Hello', 'webpack'], ' ');
element.classList.add('hello');

+ // Add the image to our existing div.
+ var myIcon = new Image();
+ let myIcon = new Image();
+ myIcon.src = Icon;
+
+ element.appendChild(myIcon);
Expand Down Expand Up @@ -463,14 +463,14 @@ __src/index.js__
+ import Data from './data.xml';

function component() {
var element = document.createElement('div');
let element = document.createElement('div');

// Lodash, now imported by this script
element.innerHTML = _.join(['Hello', 'webpack'], ' ');
element.classList.add('hello');

// Add the image to our existing div.
var myIcon = new Image();
let myIcon = new Image();
myIcon.src = Icon;

element.appendChild(myIcon);
Expand Down Expand Up @@ -588,14 +588,14 @@ __src/index.js__
- import Data from './data.xml';
-
function component() {
var element = document.createElement('div');
let element = document.createElement('div');
-
- // Lodash, now imported by this script
element.innerHTML = _.join(['Hello', 'webpack'], ' ');
- element.classList.add('hello');
-
- // Add the image to our existing div.
- var myIcon = new Image();
- let myIcon = new Image();
- myIcon.src = Icon;
-
- element.appendChild(myIcon);
Expand Down
16 changes: 10 additions & 6 deletions src/content/guides/caching.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ __webpack.config.js__
module.exports = {
entry: './src/index.js',
plugins: [
new CleanWebpackPlugin(['dist']),
// new CleanWebpackPlugin(['dist/*']) for < v2 versions of CleanWebpackPlugin
new CleanWebpackPlugin(),
new HtmlWebpackPlugin({
-       title: 'Output Management'
+       title: 'Caching'
Expand Down Expand Up @@ -103,7 +104,8 @@ __webpack.config.js__
module.exports = {
entry: './src/index.js',
plugins: [
new CleanWebpackPlugin(['dist']),
// new CleanWebpackPlugin(['dist/*']) for < v2 versions of CleanWebpackPlugin
new CleanWebpackPlugin(),
new HtmlWebpackPlugin({
      title: 'Caching'
})
Expand Down Expand Up @@ -147,7 +149,8 @@ __webpack.config.js__
module.exports = {
entry: './src/index.js',
plugins: [
new CleanWebpackPlugin(['dist']),
// new CleanWebpackPlugin(['dist/*']) for < v2 versions of CleanWebpackPlugin
new CleanWebpackPlugin(),
new HtmlWebpackPlugin({
      title: 'Caching'
}),
Expand Down Expand Up @@ -218,7 +221,7 @@ __src/index.js__
+ import Print from './print';

function component() {
var element = document.createElement('div');
let element = document.createElement('div');

// Lodash, now imported by this script
element.innerHTML = _.join(['Hello', 'webpack'], ' ');
Expand Down Expand Up @@ -261,7 +264,8 @@ __webpack.config.js__
module.exports = {
entry: './src/index.js',
plugins: [
new CleanWebpackPlugin(['dist']),
// new CleanWebpackPlugin(['dist/*']) for < v2 versions of CleanWebpackPlugin
new CleanWebpackPlugin(),
new HtmlWebpackPlugin({
title: 'Caching'
}),
Expand Down Expand Up @@ -309,7 +313,7 @@ __src/index.js__
+ // import Print from './print';

function component() {
var element = document.createElement('div');
let element = document.createElement('div');

// Lodash, now imported by this script
element.innerHTML = _.join(['Hello', 'webpack'], ' ');
Expand Down
8 changes: 4 additions & 4 deletions src/content/guides/code-splitting.md
Original file line number Diff line number Diff line change
Expand Up @@ -217,12 +217,12 @@ __src/index.js__
-
- function component() {
+ function getComponent() {
- var element = document.createElement('div');
- let element = document.createElement('div');
-
- // Lodash, now imported by this script
- element.innerHTML = _.join(['Hello', 'webpack'], ' ');
+ return import(/* webpackChunkName: "lodash" */ 'lodash').then(({ default: _ }) => {
+ var element = document.createElement('div');
+ let element = document.createElement('div');
+
+ element.innerHTML = _.join(['Hello', 'webpack'], ' ');
+
Expand Down Expand Up @@ -258,14 +258,14 @@ __src/index.js__
- function getComponent() {
+ async function getComponent() {
- return import(/* webpackChunkName: "lodash" */ 'lodash').then({ default: _ } => {
- var element = document.createElement('div');
- let element = document.createElement('div');
-
- element.innerHTML = _.join(['Hello', 'webpack'], ' ');
-
- return element;
-
- }).catch(error => 'An error occurred while loading the component');
+ var element = document.createElement('div');
+ let element = document.createElement('div');
+ const { default: _ } = await import(/* webpackChunkName: "lodash" */ 'lodash');
+
+ element.innerHTML = _.join(['Hello', 'webpack'], ' ');
Expand Down
51 changes: 11 additions & 40 deletions src/content/guides/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,11 @@ __webpack.config.js__
print: './src/print.js'
},
plugins: [
new CleanWebpackPlugin(['dist']),
// new CleanWebpackPlugin(['dist/*']) for < v2 versions of CleanWebpackPlugin
new CleanWebpackPlugin(),
new HtmlWebpackPlugin({
title: 'Development'
- title: 'Output Management'
+ title: 'Development'
})
],
output: {
Expand Down Expand Up @@ -214,7 +216,8 @@ __webpack.config.js__
+ contentBase: './dist'
+ },
plugins: [
new CleanWebpackPlugin(['dist']),
// new CleanWebpackPlugin(['dist/*']) for < v2 versions of CleanWebpackPlugin
new CleanWebpackPlugin(),
new HtmlWebpackPlugin({
title: 'Development'
})
Expand All @@ -236,29 +239,14 @@ __package.json__

``` diff
{
"name": "development",
"version": "1.0.0",
"description": "",
"main": "webpack.config.js",
...
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"watch": "webpack --watch",
+ "start": "webpack-dev-server --open",
"build": "webpack"
},
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"clean-webpack-plugin": "^0.1.16",
"css-loader": "^0.28.4",
"csv-loader": "^2.1.1",
"file-loader": "^0.11.2",
"html-webpack-plugin": "^2.29.0",
"style-loader": "^0.18.2",
"webpack": "^3.0.0",
"xml-loader": "^1.2.1"
}
...
}
```

Expand Down Expand Up @@ -301,7 +289,7 @@ __webpack.config.js__
plugins: [
new CleanWebpackPlugin(['dist']),
new HtmlWebpackPlugin({
title: 'Output Management'
title: 'Development'
})
],
output: {
Expand Down Expand Up @@ -357,32 +345,15 @@ __package.json__

``` diff
{
"name": "development",
"version": "1.0.0",
"description": "",
"main": "webpack.config.js",
...
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"watch": "webpack --watch",
"start": "webpack-dev-server --open",
+ "server": "node server.js",
"build": "webpack"
},
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"clean-webpack-plugin": "^0.1.16",
"css-loader": "^0.28.4",
"csv-loader": "^2.1.1",
"express": "^4.15.3",
"file-loader": "^0.11.2",
"html-webpack-plugin": "^2.29.0",
"style-loader": "^0.18.2",
"webpack": "^3.0.0",
"webpack-dev-middleware": "^1.12.0",
"xml-loader": "^1.2.1"
}
...
}
```

Expand Down
21 changes: 12 additions & 9 deletions src/content/guides/hot-module-replacement.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,11 @@ __webpack.config.js__
+ hot: true
},
plugins: [
new CleanWebpackPlugin(['dist']),
// new CleanWebpackPlugin(['dist/*']) for < v2 versions of CleanWebpackPlugin
new CleanWebpackPlugin(),
new HtmlWebpackPlugin({
title: 'Hot Module Replacement'
- title: 'Development'
+ title: 'Hot Module Replacement'
}),
+ new webpack.HotModuleReplacementPlugin()
],
Expand All @@ -81,8 +83,8 @@ __index.js__
import printMe from './print.js';

function component() {
var element = document.createElement('div');
var btn = document.createElement('button');
let element = document.createElement('div');
let btn = document.createElement('button');

element.innerHTML = _.join(['Hello', 'webpack'], ' ');

Expand Down Expand Up @@ -178,8 +180,8 @@ __index.js__
import printMe from './print.js';

function component() {
var element = document.createElement('div');
var btn = document.createElement('button');
let element = document.createElement('div');
let btn = document.createElement('button');

element.innerHTML = _.join(['Hello', 'webpack'], ' ');

Expand Down Expand Up @@ -247,7 +249,8 @@ __webpack.config.js__
+ ]
+ },
plugins: [
new CleanWebpackPlugin(['dist']),
// new CleanWebpackPlugin(['dist/*']) for < v2 versions of CleanWebpackPlugin
new CleanWebpackPlugin(),
new HtmlWebpackPlugin({
title: 'Hot Module Replacement'
}),
Expand Down Expand Up @@ -292,8 +295,8 @@ __index.js__
+ import './styles.css';

function component() {
var element = document.createElement('div');
var btn = document.createElement('button');
let element = document.createElement('div');
let btn = document.createElement('button');

element.innerHTML = _.join(['Hello', 'webpack'], ' ');

Expand Down
8 changes: 4 additions & 4 deletions src/content/guides/lazy-loading.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ __src/index.js__
+
- async function getComponent() {
+ function component() {
var element = document.createElement('div');
let element = document.createElement('div');
- const _ = await import(/* webpackChunkName: "lodash" */ 'lodash');
+ var button = document.createElement('button');
+ var br = document.createElement('br');
+ let button = document.createElement('button');
+ let br = document.createElement('br');

+ button.innerHTML = 'Click me and look at the console!';
element.innerHTML = _.join(['Hello', 'webpack'], ' ');
Expand All @@ -66,7 +66,7 @@ __src/index.js__
+ // Note that because a network request is involved, some indication
+ // of loading would need to be shown in a production-level site/app.
+ button.onclick = e => import(/* webpackChunkName: "print" */ './print').then(module => {
+ var print = module.default;
+ let print = module.default;
+
+ print();
+ });
Expand Down
4 changes: 2 additions & 2 deletions src/content/guides/output-management.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ __src/index.js__
+ import printMe from './print.js';

function component() {
var element = document.createElement('div');
+ var btn = document.createElement('button');
let element = document.createElement('div');
+ let btn = document.createElement('button');

element.innerHTML = _.join(['Hello', 'webpack'], ' ');

Expand Down
28 changes: 5 additions & 23 deletions src/content/guides/production.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ __webpack.common.js__
+ app: './src/index.js'
+ },
+ plugins: [
+ new CleanWebpackPlugin(['dist']),
+ // new CleanWebpackPlugin(['dist/*']) for < v2 versions of CleanWebpackPlugin
+ new CleanWebpackPlugin(),
+ new HtmlWebpackPlugin({
+ title: 'Production'
+ })
Expand Down Expand Up @@ -115,33 +116,14 @@ __package.json__

``` diff
{
"name": "development",
"version": "1.0.0",
"description": "",
"main": "src/index.js",
...
"scripts": {
- "start": "webpack-dev-server --open",
+ "start": "webpack-dev-server --open --config webpack.dev.js",
- "build": "webpack"
+ "build": "webpack --config webpack.prod.js"
},
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"clean-webpack-plugin": "^0.1.17",
"css-loader": "^0.28.4",
"csv-loader": "^2.1.1",
"express": "^4.15.3",
"file-loader": "^0.11.2",
"html-webpack-plugin": "^2.29.0",
"style-loader": "^0.18.2",
"webpack": "^3.0.0",
"webpack-dev-middleware": "^1.12.0",
"webpack-dev-server": "^2.9.1",
"webpack-merge": "^4.1.0",
"xml-loader": "^1.2.1"
}
...
}
```

Expand Down Expand Up @@ -176,7 +158,7 @@ __src/index.js__
+ }

function component() {
var element = document.createElement('pre');
let element = document.createElement('pre');

element.innerHTML = [
'Hello webpack!',
Expand Down
Loading