Route WEB_FEATURES.yml changes to web-features contributors #255
Conversation
|
This depends on #254 and I'd like to rebase it after that lands. |
| reviewers.sort(); | ||
|
|
||
| assert.deepEqual(reviewers, [ | ||
| 'annevk', 'jdm', 'zqzhang' |
There was a problem hiding this comment.
In other words, if a PR touches both WEB_FEATURES.yml and tests, it gets routed only to the regular reviewers. I think this is best for the long term, that we don't expect web-features maintainers to review every such change. We just want to reduce the noise from changes that are purely web-features.
There was a problem hiding this comment.
This makes sense for now. And we can always improve the linting (for example, linting based on the vendored data.json) to help regular reviewers have confidence in those changes.
There was a problem hiding this comment.
Yeah, that would be good even if you and I are the only reviewers, because we'll never catch all minor typos :)
Fixes #253.