Route WEB_FEATURES.yml changes to web-features contributors

Fixes #253.

Author: foolip

lib/metadata/find-owners.js

@@ -1,8 +1,12 @@
 "use strict";
 var github = require('../github'),
+    paths = require('./paths'),
     uniq = require('../uniq'),
     yaml = require('js-yaml');
 
+// https://github.com/web-platform-tests/rfcs/blob/master/rfcs/web_features.md#step-4-adjust-the-wpt-pr-bot-to-handle-reviews-of-the-changes
+var webFeaturesReviewers = ['foolip', 'jcscottiii'];
+
 function getReviewersFile(path, reviewers) {
     return github.get("/repos/:owner/:repo/contents/:path", { path: path + "/META.yml" })
         .then(function(file) {
@@ -36,9 +40,15 @@ function parentDir(path) {
     return path.join("/");
 }
 
-module.exports = async function(_directories) {
+module.exports = async function(filenames) {
+    // If only WEB_FEATURES.yml files are touched, route the review to
+    // web-features contributors.
+    if (filenames.every((filename) => filename.endsWith('/WEB_FEATURES.yml'))) {
+        return webFeaturesReviewers;
+    }
+
     var reviewers = [];
-    var directories = _directories.slice(0);
+    var directories = paths(filenames).slice(0);
     // Reversing the array here keeps compatibility with a previous version of
     // this code, which used a recursive structure and called pop() on the
     // array each time. This could likely be removed with some investigation.

lib/metadata/index.js

@@ -1,7 +1,6 @@
 "use strict";
 
 const getFilenames = require('./filenames'),
-      paths = require('./paths'),
       findSpecs = require('./find-specs'),
       findOwners = require('./find-owners'),
       findRemovedReviewers = require('./find-removed-reviewers'),
@@ -50,7 +49,6 @@ module.exports = async function getMetadata(number, author, title, content) {
     author = author.toLowerCase();
 
     metadata.filenames = await getFilenames(number);
-    metadata.paths = paths(metadata.filenames);
     const fileLabels = labels.fromFiles(metadata.filenames);
     metadata.isRoot = metadata.filenames.some(function(path) {
         return path.split('/').length == 1;
@@ -63,7 +61,7 @@ module.exports = async function getMetadata(number, author, title, content) {
         fileLabels, labels.fromWorkingGroups(metadata.workingGroups)
     );
 
-    let reviewers = await findOwners(metadata.paths);
+    let reviewers = await findOwners(metadata.filenames);
 
     const removedReviewers = await findRemovedReviewers(number);
     reviewers = reviewers.filter(function(reviewer) {

test/find-owners.js

@@ -31,7 +31,7 @@ suite('parse META', function() {
 
 suite('integration', function() {
     test('directory contains file', function() {
-        return findOwners(['resources'])
+        return findOwners(['resources/testharness.js'])
           .then(function(reviewers) {
               reviewers.sort();
 
@@ -40,24 +40,46 @@ suite('integration', function() {
     });
 
     test('parent directory contains file', function() {
-        return findOwners(['2dcontext/scroll'])
+        return findOwners(['dom/nodes/attributes.html'])
           .then(function(reviewers) {
               reviewers.sort();
 
               assert.deepEqual(reviewers, [
-                  'AmeliaBR', 'annevk', 'fserb', 'jdashg', 'kenrussell'
+                  'annevk', 'jdm', 'zqzhang'
               ]);
           });
     });
 
     test('consolidation of multiple directories', function() {
-        return findOwners(['resources', '2dcontext'])
+        return findOwners(['resources/testharness.js', 'dom/nodes/attributes.html'])
           .then(function(reviewers) {
               reviewers.sort();
 
               assert.deepEqual(reviewers, [
-                  'AmeliaBR', 'annevk', 'ayg', 'fserb', 'gsnedders',
-                  'jdashg', 'jgraham', 'kenrussell'
+                  'annevk', 'ayg', 'gsnedders',
+                  'jdm', 'jgraham', 'zqzhang'
+              ]);
+          });
+    });
+
+    test('only WEB_FEATURES.yml changes', function() {
+        return findOwners(['dom/WEB_FEATURES.yml'])
+          .then(function(reviewers) {
+              reviewers.sort();
+
+              assert.deepEqual(reviewers, [
+                  'foolip', 'jcscottiii'
+              ]);
+          });
+    });
+
+    test('WEB_FEATURES.yml and test changes', function() {
+        return findOwners(['dom/WEB_FEATURES.yml', 'dom/nodes/attributes.html'])
+          .then(function(reviewers) {
+              reviewers.sort();
+
+              assert.deepEqual(reviewers, [
+                  'annevk', 'jdm', 'zqzhang'
               ]);
           });
     });

test/get-metadata.js

@@ -56,7 +56,6 @@ suite('getMetadata', function() {
             ],
             rootReviewers: [ 'jgraham' ],
             filenames: [ 'WebIDL/interfaces.html', 'interfaces/WebIDL.idl' ],
-            paths: [ 'WebIDL', 'interfaces' ],
             labels: [ 'WebIDL', 'interfaces', 'wg-webplatform' ],
             isRoot: false,
             isWebKitVerified: false,
@@ -167,10 +166,6 @@ suite('getMetadata', function() {
               permission: "write"
             }
           ],
-          paths: [
-            "svg/coordinate-systems",
-            "svg/coordinate-systems/parsing",
-          ],
           reviewedDownstream: null,
           reviewers: [
             "ameliabr",
@@ -380,7 +375,6 @@ suite('getMetadata', function() {
                'media-source/webm/test-a-1s.webm-manifest.json',
                'media-source/webm/test-v-1s-blue.webm',
                'media-source/webm/test-v-1s-blue.webm-manifest.json' ],
-            paths: [ '', 'media-source', 'media-source/mp4', 'media-source/webm' ],
             isRoot: true,
             specs:
              { 'media-source':