Adding missing feature descriptions - Batch 10 #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 28, 2024
Merged
foolip
reviewed
Apr 12, 2024
captainbrosset
commented
Apr 15, 2024
There was a problem hiding this comment.
This is making me wonder if we should call this feature discrete-transition-behavior.yml instead.
There was a problem hiding this comment.
I think using the CSS property name is a good default. Some features are named for a property + value pair, and in this case that would be transition-behavior-allow-discrete.yml. But we don't know for sure that there will ever be another interesting value, so I think sticking with just transition-behavior.yml until that time works.
Co-authored-by: Philip Jägenstedt <[email protected]>
github-actions
bot
added
the
feature definition
Co-authored-by: Patrick Brosset <[email protected]>
foolip
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.