Adding missing descriptions and making them mandatory/published #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
foolip
reviewed
Mar 27, 2024
This comment was marked as outdated.
This comment was marked as outdated.
|
@captainbrosset I see that you resolved conflicts, but by replacing the original descriptions. Unless you think they're bad, can you back those changes out to focus only on missing descriptions? |
|
Thinking about how to get this done with maximum velocity, I think having a single big PR is going to lead to a lot of good descriptions being held back by discussions on a few tricky cases. I would suggest splitting this into many small PRs, perhaps not one per descriptions, but at most 10 per PR so that review comments are manageable on each. Other than alphabetically, I think the easiest split would be by spec, and would do some amount of useful clustering. |
|
Closing this PR and opening multiple smaller PRs instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR describes all the features that don't yet have a description field. Fixes #736.
This PR also makes the description field mandatory so that, going forward, we have to have descriptions.
Reviewers: most of this is taken from MDN, Can I Use, specs, and Wikipedia. My goal was to cover 100% of files, not to be 100% correct on all of them. I believe that once we have the descriptions in place, at least, we can't introduce new features without descriptions, but we can always improve the existing ones.